Summary: | Patron name not showing on issuehistory.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Liz Rea <liz> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart+koha> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart+koha, josef.moravec, martin.renvoize, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 18403 | ||
Bug Blocks: | 20934, 21432 | ||
Attachments: |
Bug 20899: Fix patron's name display
Bug 20899: Fix patron's name display Bug 20899: Fix patron's name display Bug 20899: Fix patron's name display |
Description
Liz Rea
2018-06-08 03:23:42 UTC
Caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Created attachment 75975 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Created attachment 75998 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected :) Created attachment 76027 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 76042 [details] [review] Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Patch amended, td tag was not closed! Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.01 Depends on Bug 18403 not in 17.11.x |