Description
Nick Clemens (kidclamp)
2018-06-26 15:01:49 UTC
Created attachment 76453 [details] [review] Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Created attachment 76455 [details] [review] Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 76456 [details] [review] Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Upping severity, that's clearly critical for installations with IndependentBranches. I have added a follow-up to simplify the conditional statement. Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron Created attachment 76466 [details] [review] Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 76467 [details] [review] Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 76517 [details] [review] Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 76518 [details] [review] Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Awesome work all! Pushed to master for 18.11 Request for back-port (issue first occurs in 17.11, I believe) Pushed to 18.05.x for 18.05.02 Pushed to 17.11.x for 17.11.08 Depends on Bug 17829 not in 17.05.x |