Bug 20999

Summary: Remove invalid 'style="block"' from OPAC templates
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: fridolin.somers, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 20999: Remove invalid 'style="block"' from OPAC templates
Bug 20999: Remove invalid 'style="block"' from OPAC templates
Bug 20999: Remove invalid 'style="block"' from OPAC templates

Description Owen Leonard 2018-06-26 15:12:53 UTC
There are a few instances of the invalid 'style="block"' attribute in the OPAC templates. They should be removed.
Comment 1 Owen Leonard 2018-06-26 16:27:59 UTC
Created attachment 76458 [details] [review]
Bug 20999: Remove invalid 'style="block"' from OPAC templates

This patch removes an invalid attribute from OPAC template markup. There
should be no visible change to the OPAC.

To test, apply the patch and confirm that the following pages still look
correct when using various cover image sources: Coce, Amazon, Google:

 - Bibliographic detail page (opac-detail.pl)
   - The shelf browser
 - Catalog search results
 - Recent comments
Comment 2 Charles Farmer 2018-06-29 21:33:55 UTC
Created attachment 76598 [details] [review]
Bug 20999: Remove invalid 'style="block"' from OPAC templates

This patch removes an invalid attribute from OPAC template markup. There
should be no visible change to the OPAC.

To test, apply the patch and confirm that the following pages still look
correct when using various cover image sources: Coce, Amazon, Google:

 - Bibliographic detail page (opac-detail.pl)
   - The shelf browser
 - Catalog search results
 - Recent comments

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 3 Katrin Fischer 2018-07-01 19:01:29 UTC
Created attachment 76605 [details] [review]
Bug 20999: Remove invalid 'style="block"' from OPAC templates

This patch removes an invalid attribute from OPAC template markup. There
should be no visible change to the OPAC.

To test, apply the patch and confirm that the following pages still look
correct when using various cover image sources: Coce, Amazon, Google:

 - Bibliographic detail page (opac-detail.pl)
   - The shelf browser
 - Catalog search results
 - Recent comments

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Nick Clemens 2018-07-02 13:16:03 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-07-02 17:09:36 UTC
Pushed to 18.05.x for 18.05.02
Comment 6 Fridolin Somers 2018-07-04 14:31:24 UTC
Pushed to 17.11.x for 17.11.08