Summary: | Refining a search made on a specific index fail | ||
---|---|---|---|
Product: | Koha | Reporter: | Alex Arnaud <alex.arnaud> |
Component: | Searching - Elasticsearch | Assignee: | Alex Arnaud <alex.arnaud> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nicolas.legrand, severine.queune, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 21032 - fix using facet for searches made on specific index
Bug 21032 - fix using facet for searches made on specific index Bug 21032 - fix using facet for searches made on specific index Bug 21032: Fix using facet for searches made on specific index |
Description
Alex Arnaud
2018-07-03 13:43:19 UTC
Created attachment 76653 [details] [review] Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Thanks for this patch ! It works correctly except when facets end with punctuation. Status set to 'Failed', sorry Alex :( (In reply to Séverine Queune from comment #2) > Thanks for this patch ! > It works correctly except when facets end with punctuation. > Status set to 'Failed', sorry Alex :( Hello Séverine, Thanks for testing! In my opinion, this should be a separate bug. But i'm not able to reproduce this issue. I have a search result with 2 different facets: "Pakita," and "Pakita". Clicking one or the other, it works and i get the same results for the two. Created attachment 76884 [details] [review] Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Tested in our 2 different instances (dev and test) and both work ! The problem I mentioned on comment 2 seems to be specific to the sandbox. Thank you Alex ! Created attachment 77332 [details] [review] Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 77335 [details] [review] Bug 21032: Fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master, thanks! Pushed to 18.05.x for 18.05.03. Pushed to 17.11.x for 17.11.09 |