Summary: | patron attribute classes break patron's edit view | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Patrons | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, katrin.fischer, kyle.m.hall, liz, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 7154 | ||
Bug Blocks: | |||
Attachments: |
Bug 21080: Fix patron's attributes display when PA_CLASS is used
Bug 21080: Fix patron's attributes display when PA_CLASS is used Bug 21080: Fix patron's attributes display when PA_CLASS is used |
Description
Jonathan Druart
2018-07-16 22:45:16 UTC
Hum, maybe it comes from local changes. I've seen this too, just now. Not sure what local change could have done it tbh. Did you solve it, Jonathan? I think bug 20828 broke this - the attributes fall back in line when the homebound feature is enabled. I confirm it still exists indeed. (In reply to Jonathan Druart from comment #0) > To recreate: > 1. Create 1+ authorised values PA_CLASS > 2. Create patron's attributes using it > 3. Edit a patron 4. Turn HouseboundModule on (In reply to Jonathan Druart from comment #0) > To recreate: > 1. Create 1+ authorised values PA_CLASS > 2. Create patron's attributes using it > 3. Edit a patron 4. Turn HouseboundModule off (!) Ha, it does not happen 100% of the time, it depends on the order of the fieldset and the ol elements Created attachment 81598 [details] [review] Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Created attachment 81617 [details] [review] Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Created attachment 81645 [details] [review] Bug 21080: Fix patron's attributes display when PA_CLASS is used When a patron attribute class (AV PA_CLASS) is created, the patron's edit view is broken: https://screenshots.firefox.com/62uNhoUtH6rPXm9l/pro.kohadev.org To recreate: 1. Create 1+ authorised values PA_CLASS 2. Create patron's attributes using it 3. Edit a patron it depends on the order of the fieldset and the ol elements This is certainly not the best fix but the display does not look broken! Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Took a little bit of playing, but see the error and confirm it's fixed! Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 Pushed to 17.11.x for 17.11.13 |