Created attachment 77364 [details] [review] Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Created attachment 77365 [details] [review] Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. There is no exhaustive test plan here, reading the patch and hitting few opac pages should do the work. Also try with logged-in patrons - with a category 'organization' - with/without title Created attachment 77369 [details] [review] Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Created attachment 77370 [details] [review] Bug 21137: use logged_in_user from opac-user.pl Created attachment 77371 [details] [review] Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. Created attachment 77376 [details] [review] Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 77377 [details] [review] Bug 21137: use logged_in_user from opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 77378 [details] [review] Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 77397 [details] [review] Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77398 [details] [review] Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77399 [details] [review] Bug 21137: use logged_in_user from opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77400 [details] [review] Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Smuggled in a small follow-up - same pattern as patch on bug 19291. Created attachment 77401 [details] [review] Bug 21137: Replace USER_INFO with logged_in_user This patch set does several things: - it removes USER_INFO and BORROWER_INFO These 2 variables contained logged-in patron's info. They must be accessed from logged_in_user - Use patron-title.inc for the breadcrumb at the OPAC, for consistencies Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77402 [details] [review] Bug 21137: use logged_in_user from opac-user.pl Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77403 [details] [review] Bug 21137: Replace BORROWER_INFO with logged_in_user it also removes 'category_type' and 'description' from a couple of opac scripts, they are not needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77404 [details] [review] Bug 21137: Standardize breadcrumbs for tags page Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05 x at this time. |
We now have a Koha::Patron object sent to the templates, logged_in_user. It must be used everywhere patron's info are needed. BORROWER_INFO and USER_INFO can be replaced using it. See commit d2f2590c894efca417112795e05248dbd16636f5 Bug 18403: Send logged_in_user to template from C4::Auth