If the user is logged in the search history can be accessed from within the patron account. In this case the breadcrumbs are not consistent with the other patron account pages in that the name of the logged-in user is missing. Patch might take into account that there is an anomymous search history too.
Created attachment 77309 [details] [review] Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history
Created attachment 77312 [details] [review] Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works.
Other files have the patron.title displayed.
(In reply to Jonathan Druart from comment #3) > Other files have the patron.title displayed. Well, not all... Should not we fix everything at once on this bug report?
Do you mean all other pages or just this one? If the patron title is not on all pages, maybe this could be a separate bug?
With this patch we are fixing half of the inconsistency, so yes we could fix that on a separate bug report, if you prefer.
Created attachment 77363 [details] [review] Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #6) > With this patch we are fixing half of the inconsistency, so yes we could fix > that on a separate bug report, if you prefer. See bug 21137
Created attachment 77405 [details] [review] Bug 19291: Make breadcrumbs for OPAC search history consistent with other patron account pages This patch adds the logged-in patron's name to the search history page's breadcrumb navigation. To test, apply the patch and view the OPAC search history page with no user logged in. The breadcrumbs should read: - Home -> Search history Log in and return to the search history page. The breadcrumbs should read: - Home -> Owen Leonard -> Your search history Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Followed the test plan and it works. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=21137
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Pushed to 17.11.x for 17.11.10