Summary: | SRU search fields mapping pop-up comes up empty | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | System Administration | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, julian.maurice, m.de.rooy, martin.renvoize, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 19436 | ||
Bug Blocks: | 21243 | ||
Attachments: |
Bug 21151: Fix SRU search fields mapping pop-up
Bug 21151: Fix SRU search fields mapping pop-up Bug 21151: Fix SRU search fields mapping pop-up |
Description
Katrin Fischer
2018-08-02 22:43:04 UTC
Created attachment 77460 [details] [review] Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch. Created attachment 77468 [details] [review] Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch. https://bugs.koha-community.org/show_bug.cgi?id=21141 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Part of this fix is already in bug 19436. Waiting for a push too long already. Created attachment 77551 [details] [review] Bug 21151: Fix SRU search fields mapping pop-up The SRU search fields mapping pop-up comes up as a blank white page. To test: - Go to Administration > Z39.50/SRU servers - Modify or create an SRU server - Click on the 'Modify' button to change mappings - Verify the new window that opens is blank - Apply patch - Verify the pop-up now is no longer blank but works correctly. Bonus: Spottd some HTML errors while looking for the problem. Also fixed in the patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> (In reply to Marcel de Rooy from comment #3) > Part of this fix is already in bug 19436. Waiting for a push too long > already. I think this will be useful as a quick fix and for backporting to 18.05 as a bugfix. But also keen on the functionality of 19436 for 18.11. Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.03 Patch was broken when resolving a conflict I guess, patch in master and 18.05 is NOT my patch. Instead of fixing, it now breaks everything. |