Bug 21163

Summary: Basket group detail page layout is broken
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: jonathan.druart, julian.maurice, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Small patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 20667    
Bug Blocks:    
Attachments: Bug 21163: Basket group detail page layout is broken
Bug 21163: Basket group detail page layout is broken
Bug 21163: Basket group detail page layout is broken
Bug 21163: Basket group detail page layout is broken

Description Josef Moravec 2018-08-06 10:55:11 UTC
See this screenshot:

https://screenshots.firefox.com/UXubeSlczdiSCxQg/localhost

the main part of the page is out of it's position
Comment 1 Owen Leonard 2018-08-06 14:05:56 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2018-08-06 14:17:46 UTC
I would have preferred a patch with only the needed changes, this wants does too many things.

At least one bug: deliverycomment textarea is not displayed when creating a new basket group.

Indentation of last patch of the patch looks weird, it should be 1 input per line  (here it is sometimes 1, 2 or 3).
Comment 3 Owen Leonard 2018-08-06 14:35:45 UTC
Created attachment 77489 [details] [review]
Bug 21163: Basket group detail page layout is broken

This fixes a problem with layout of the page when viewing a closed
basket group. Changed the grid options for basket information when a
basket group is closed.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups. You should have multiple baskets and basket groups to test with.

- Edit an open basket group. The layout should look correct, with basket
  group information in the form in the left column and ungrouped basket
  in the right column. Grouping and ungrouping baskets should work
  correctly.
- View a closed basket group. The basket group information should
  display in a single column that spans the main part of the page.
Comment 4 Jonathan Druart 2018-08-06 15:03:13 UTC
Created attachment 77492 [details] [review]
Bug 21163: Basket group detail page layout is broken

This fixes a problem with layout of the page when viewing a closed
basket group. Changed the grid options for basket information when a
basket group is closed.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups. You should have multiple baskets and basket groups to test with.

- Edit an open basket group. The layout should look correct, with basket
  group information in the form in the left column and ungrouped basket
  in the right column. Grouping and ungrouping baskets should work
  correctly.
- View a closed basket group. The basket group information should
  display in a single column that spans the main part of the page.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 5 Julian Maurice 2018-08-08 08:04:05 UTC
Created attachment 77552 [details] [review]
Bug 21163: Basket group detail page layout is broken

This fixes a problem with layout of the page when viewing a closed
basket group. Changed the grid options for basket information when a
basket group is closed.

To test, apply the patch and go to Acquisitions -> Vendor -> Basket
groups. You should have multiple baskets and basket groups to test with.

- Edit an open basket group. The layout should look correct, with basket
  group information in the form in the left column and ungrouped basket
  in the right column. Grouping and ungrouping baskets should work
  correctly.
- View a closed basket group. The basket group information should
  display in a single column that spans the main part of the page.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 6 Nick Clemens (kidclamp) 2018-08-08 21:34:58 UTC
Awesome work all!

Pushed to master for 18.11
Comment 7 Martin Renvoize (ashimema) 2018-08-09 10:09:54 UTC
Depends on (and is caused by) but 20667 which is not in 18.05.x series.