See this screenshot: https://screenshots.firefox.com/UXubeSlczdiSCxQg/localhost the main part of the page is out of it's position
Created attachment 77488 [details] [review] Bug 21163: Basket group detail page layout is broken This patch makes markup changes and improvements to the basket groups template. This fixes a problem with layout of the page when viewing a closed basket group. Fixed: Changed the grid options for basket information when a basket group is closed. Also changed: Removed some unnecessary script and style "type" attributes. Rearranged some list markup in order to avoid validation errors. Removed some id attributes which were causing validation error. Added some minor style changes to improve readability. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. - HTML validation of the page should contain no relevant errors.
I would have preferred a patch with only the needed changes, this wants does too many things. At least one bug: deliverycomment textarea is not displayed when creating a new basket group. Indentation of last patch of the patch looks weird, it should be 1 input per line (here it is sometimes 1, 2 or 3).
Created attachment 77489 [details] [review] Bug 21163: Basket group detail page layout is broken This fixes a problem with layout of the page when viewing a closed basket group. Changed the grid options for basket information when a basket group is closed. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page.
Created attachment 77492 [details] [review] Bug 21163: Basket group detail page layout is broken This fixes a problem with layout of the page when viewing a closed basket group. Changed the grid options for basket information when a basket group is closed. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 77552 [details] [review] Bug 21163: Basket group detail page layout is broken This fixes a problem with layout of the page when viewing a closed basket group. Changed the grid options for basket information when a basket group is closed. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Awesome work all! Pushed to master for 18.11
Depends on (and is caused by) but 20667 which is not in 18.05.x series.