Summary: | C4::Acquisition - Remove GetOrderFromItemnumber | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | m.de.rooy, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15184, 21202 | ||
Bug Blocks: | 21204, 21206, 22360 | ||
Attachments: |
Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls
Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber |
Description
Jonathan Druart
2018-08-10 15:26:40 UTC
Koha::Acquisition::Order->items comes from bug 15184 Created attachment 77698 [details] [review] Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Created attachment 78042 [details] [review] Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 78043 [details] [review] Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> perl t/db_dependent/Acquisition/CancelReceipt.t 1..12 The method Koha::Acquisition::Order->items is not covered by tests! perl t/db_dependent/Acquisition/TransferOrder.t 1..13 ok 1 - 1 order in basket1 The method Koha::Acquisition::Order->items is not covered by tests! Koha::Acquisition::Order->items is added by bug 15184 QA: Looking here Created attachment 78319 [details] [review] Bug 21205: Replace C4::Items::GetOrderFromItemnumber calls This is done to ease the move of C4::Items (bug 18252) to Koha::Items my @itemnumbers = GetItemnumbersFromOrder($order->{ordernumber}); will become my @itemnumbers = $order_object->items->get_column('itemnumbers'); Test plan: - Create an order with several items - Receive some items Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 78320 [details] [review] Bug 21205: (follow-up) Fix column name - itemnumbers -> itemnumber Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Passed QA but note that 15184 is in FQA now. Please wait, RM. Added a temporary flag in the title. Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |