Bug 21213

Summary: Circulation.t needs diagnostics
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, martin.renvoize, nick
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20721    
Bug Blocks: 25551, 22917    
Attachments: Bug 21213: Add diagnostics to Circulation.t

Description Jonathan Druart 2018-08-13 14:54:01 UTC
koha_1       |     #   Failed test 'Test at line 1896'
koha_1       |     #   at t/db_dependent/Circulation.t line 2424.
koha_1       |     #          got: '0'
koha_1       |     #     expected: '1'
koha_1       | 
koha_1       |     #   Failed test 'Test at line 1896'
koha_1       |     #   at t/db_dependent/Circulation.t line 2427.
koha_1       |     #          got: undef
koha_1       |     #     expected: '2018-08-25'
koha_1       |     # Looks like you failed 2 tests of 14.
koha_1       | 
koha_1       | #   Failed test 'AddReturn + suspension_chargeperiod'
koha_1       | #   at t/db_dependent/Circulation.t line 1905.
koha_1       | # Looks like you failed 1 test of 118.
koha_1       | [19:23:06] t/db_dependent/Circulation.t
Comment 1 Jonathan Druart 2018-08-13 14:54:31 UTC
I have no idea why this is failing.
Comment 2 Jonathan Druart 2018-08-13 14:55:57 UTC
Created attachment 77754 [details] [review]
Bug 21213: Add diagnostics to Circulation.t

Jenkins reported failures on a D9 run. No idea why it is failing so
adding diag and wait for the next failure.
Comment 3 Nick Clemens 2018-08-14 12:57:50 UTC
Trivial patch to enhance debugging, skipping SO/QA

Pushed to master for 18.11
Comment 4 Martin Renvoize 2018-08-16 14:25:47 UTC
Pushed to 18.05.x for 18.05.03
Comment 5 Fridolin Somers 2018-09-21 13:02:50 UTC
Does not apply easy on 17.11.x but UT t/db_dependent/Circulation.t is actually OK
Comment 6 Jonathan Druart 2018-09-21 13:12:46 UTC
(In reply to Fridolin SOMERS from comment #5)
> Does not apply easy on 17.11.x but UT t/db_dependent/Circulation.t is
> actually OK

They are random failures.
Comment 7 Fridolin Somers 2018-09-24 15:04:29 UTC
(In reply to Jonathan Druart from comment #6)
> (In reply to Fridolin SOMERS from comment #5)
> > Does not apply easy on 17.11.x but UT t/db_dependent/Circulation.t is
> > actually OK
> 
> They are random failures.

Ah ok.
I'll push if a patch is created for 17.11.x
Comment 8 Jonathan Druart 2019-02-28 13:54:24 UTC
It failed on last run!

koha_1       |     #   Failed test 'AddReturn must have debarred the patron'
koha_1       |     #   at t/db_dependent/Circulation.t line 2976.
koha_1       |     #          got: ''
koha_1       |     #     expected: '1'
koha_1       |     # AddReturn returned message $VAR1 = {
koha_1       |     #           'WasReturned' => 1
koha_1       |     #         };
koha_1       | 
koha_1       |     #   Failed test 'Test at line 1845'
koha_1       |     #   at t/db_dependent/Circulation.t line 2980.
koha_1       |     #          got: '0'
koha_1       |     #     expected: '1'
koha_1       | 
koha_1       |     #   Failed test 'Test at line 1845'
koha_1       |     #   at t/db_dependent/Circulation.t line 2983.
koha_1       |     #          got: undef
koha_1       |     #     expected: '2019-03-13'
koha_1       |     # Looks like you failed 3 tests of 21.
koha_1       | 
koha_1       | #   Failed test 'AddReturn + suspension_chargeperiod'
Comment 9 Jonathan Druart 2019-05-16 00:33:26 UTC
Same today, I have a fix coming.