koha_1 | # Failed test 'Test at line 1896' koha_1 | # at t/db_dependent/Circulation.t line 2424. koha_1 | # got: '0' koha_1 | # expected: '1' koha_1 | koha_1 | # Failed test 'Test at line 1896' koha_1 | # at t/db_dependent/Circulation.t line 2427. koha_1 | # got: undef koha_1 | # expected: '2018-08-25' koha_1 | # Looks like you failed 2 tests of 14. koha_1 | koha_1 | # Failed test 'AddReturn + suspension_chargeperiod' koha_1 | # at t/db_dependent/Circulation.t line 1905. koha_1 | # Looks like you failed 1 test of 118. koha_1 | [19:23:06] t/db_dependent/Circulation.t
I have no idea why this is failing.
Created attachment 77754 [details] [review] Bug 21213: Add diagnostics to Circulation.t Jenkins reported failures on a D9 run. No idea why it is failing so adding diag and wait for the next failure.
Trivial patch to enhance debugging, skipping SO/QA Pushed to master for 18.11
Pushed to 18.05.x for 18.05.03
Does not apply easy on 17.11.x but UT t/db_dependent/Circulation.t is actually OK
(In reply to Fridolin SOMERS from comment #5) > Does not apply easy on 17.11.x but UT t/db_dependent/Circulation.t is > actually OK They are random failures.
(In reply to Jonathan Druart from comment #6) > (In reply to Fridolin SOMERS from comment #5) > > Does not apply easy on 17.11.x but UT t/db_dependent/Circulation.t is > > actually OK > > They are random failures. Ah ok. I'll push if a patch is created for 17.11.x
It failed on last run! koha_1 | # Failed test 'AddReturn must have debarred the patron' koha_1 | # at t/db_dependent/Circulation.t line 2976. koha_1 | # got: '' koha_1 | # expected: '1' koha_1 | # AddReturn returned message $VAR1 = { koha_1 | # 'WasReturned' => 1 koha_1 | # }; koha_1 | koha_1 | # Failed test 'Test at line 1845' koha_1 | # at t/db_dependent/Circulation.t line 2980. koha_1 | # got: '0' koha_1 | # expected: '1' koha_1 | koha_1 | # Failed test 'Test at line 1845' koha_1 | # at t/db_dependent/Circulation.t line 2983. koha_1 | # got: undef koha_1 | # expected: '2019-03-13' koha_1 | # Looks like you failed 3 tests of 21. koha_1 | koha_1 | # Failed test 'AddReturn + suspension_chargeperiod'
Same today, I have a fix coming.