Summary: | Grayed out Fields not always visible | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Bugs List <koha-bugs> |
Severity: | trivial | ||
Priority: | PATCH-Sent (DO NOT USE) | CC: | chris, cnighswonger, gmcharlt, julian.maurice, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
king, stephen is authorized and i cannot edit - but it looks white to me
on pc in firefox (same browser) it's gray Screenshot of proposed update Proposed fix Follow-up fix for authorities editor |
Description
Chris Cormack
2010-05-21 00:46:49 UTC
Created attachment 2470 [details]
Screenshot of proposed update
My proposed solution would add a "readonly" class to these inputs since we can't depend on browsers to consistently indicate the readonly attribute with a default color.
I also thought adding a "locked" icon might be a good way to indicate that the field is read only.
I like the way this looks! It makes it very clear. Created attachment 2480 [details] [review] Proposed fix - Adding "readonly" class to readonly fields to guarantee that readonly state is indicated visually - Adding "locked" icon to the background of readonly fields for additional visual feedback I've signed off on the patch. The authority record editor should get a parallel change. Created attachment 2756 [details] [review] Follow-up fix for authorities editor This patch depends on the previously submitted patch for the MARC editor Patches pushed, please test This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed. This bug is mentioned in: Fix for Bug 2122, Grayed out Fields not always visible http://lists.koha-community.org/pipermail/koha-patches/2010-November/013012.html Bug 2122 follow-up for authorities editor http://lists.koha-community.org/pipermail/koha-patches/2010-November/013014.html Bug 2122 follow-up for authorities editor http://lists.koha-community.org/pipermail/koha-patches/2010-November/013029.html |