Summary: | Implement blocking errors for members/memberentry.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 20661 | ||
Bug Blocks: | 21222 | ||
Attachments: |
Bug 21221: Shortcut memberentry scripts if patron does not exist
Bug 21221: Shortcut memberentry scripts if patron does not exist Bug 21221: Shortcut memberentry scripts if patron does not exist |
Description
Jonathan Druart
2018-08-14 19:24:46 UTC
Created attachment 77800 [details] [review] Bug 21221: Shortcut memberentry scripts if patron does not exist If borrowernumber is passed and that it does not refer to a valid patron in DB, we should not continue the script and display an error instead. Test plan: Create a patron Edit a patron => Both should work ok You can also test the other action memberentry.pl manage. Edit it again but modify the borrowernumber parameter => You should see a friendly user message saying that the patron does not exist. Created attachment 77810 [details] [review] Bug 21221: Shortcut memberentry scripts if patron does not exist If borrowernumber is passed and that it does not refer to a valid patron in DB, we should not continue the script and display an error instead. Test plan: Create a patron Edit a patron => Both should work ok You can also test the other action memberentry.pl manage. Edit it again but modify the borrowernumber parameter => You should see a friendly user message saying that the patron does not exist. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 77889 [details] [review] Bug 21221: Shortcut memberentry scripts if patron does not exist If borrowernumber is passed and that it does not refer to a valid patron in DB, we should not continue the script and display an error instead. Test plan: Create a patron Edit a patron => Both should work ok You can also test the other action memberentry.pl manage. Edit it again but modify the borrowernumber parameter => You should see a friendly user message saying that the patron does not exist. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> All seems solid, Passing QA Awesome work all! Pushed top master for 18.11 Pushed to 18.05.x for 18.05.03 |