Created attachment 77800 [details] [review] Bug 21221: Shortcut memberentry scripts if patron does not exist If borrowernumber is passed and that it does not refer to a valid patron in DB, we should not continue the script and display an error instead. Test plan: Create a patron Edit a patron => Both should work ok You can also test the other action memberentry.pl manage. Edit it again but modify the borrowernumber parameter => You should see a friendly user message saying that the patron does not exist.
Created attachment 77810 [details] [review] Bug 21221: Shortcut memberentry scripts if patron does not exist If borrowernumber is passed and that it does not refer to a valid patron in DB, we should not continue the script and display an error instead. Test plan: Create a patron Edit a patron => Both should work ok You can also test the other action memberentry.pl manage. Edit it again but modify the borrowernumber parameter => You should see a friendly user message saying that the patron does not exist. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 77889 [details] [review] Bug 21221: Shortcut memberentry scripts if patron does not exist If borrowernumber is passed and that it does not refer to a valid patron in DB, we should not continue the script and display an error instead. Test plan: Create a patron Edit a patron => Both should work ok You can also test the other action memberentry.pl manage. Edit it again but modify the borrowernumber parameter => You should see a friendly user message saying that the patron does not exist. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
All seems solid, Passing QA
Awesome work all! Pushed top master for 18.11
Pushed to 18.05.x for 18.05.03
Depends on Bug 20661 not in 17.11.x