Summary: | Some floating values are wrong | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 19474 | ||
Bug Blocks: | |||
Attachments: |
Bug 21223: Fix some floating values
Bug 21223: Fix some floating values Bug 21223: Fix some floating values |
Description
Jonathan Druart
2018-08-14 20:24:43 UTC
histsearch https://snag.gy/yJYbav.jpg add/edit patron https://snag.gy/hFUAqY.jpg Created attachment 77803 [details] [review] Bug 21223: Fix some floating values See description of the bug for screenshots I do not really know why we have these issues, but maybe we should regenerate the .scss in order to catch the other problems? Hum, on histsearch the .hint are misplaced too. Created attachment 77813 [details] [review] Bug 21223: Fix some floating values See description of the bug for screenshots I do not really know why we have these issues, but maybe we should regenerate the .scss in order to catch the other problems? Signed-off-by: Owen Leonard <oleonard@myacpl.org> (In reply to Jonathan Druart from comment #2) > I do not really know why we have these issues, but maybe we should > regenerate the .scss in order to catch the other problems? Bug 19474 was a really big change and when so many things are changed at once mistakes happen. It's hard to catch them all through testing. I know there are more. We'll fix them as they come up. Created attachment 77873 [details] [review] Bug 21223: Fix some floating values See description of the bug for screenshots I do not really know why we have these issues, but maybe we should regenerate the .scss in order to catch the other problems? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Needs bug 21222 for testing right now (patron creation broken) Awesome work all! Pushed to master for 18.11 Caused by 19474 not in 18.05.x branch. |