Bug 21266

Summary: Missing doc-head-close and cssinclude in sco-main.tt
Product: Koha Reporter: Alex Buckley <alexbuckley>
Component: OPACAssignee: Aleisha Amohia <aleisha>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: aleisha, dcook, hammat.wele, katrin.fischer, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt
Bug 21266: (follow-up) Removing duplicate lines and moving code around
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt
Bug 21266: (follow-up) Removing duplicate lines and moving code around
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt
Bug 21266: (follow-up) Removing duplicate lines and moving code around
Bug 21266: (follow-up) Remove unnecessary vars passed to template
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt
Bug 21266: (follow-up) Removing duplicate lines and moving code around
Bug 21266: (follow-up) Remove unnecessary vars passed to template

Description Alex Buckley 2018-08-24 02:21:18 UTC
Custom stylesheet themes set in the OpacAdditionalStylesheet are not applied to the sco-main.tt page because this page is missing the following lines of code in the header:

doc-head-close
cssinclude
Comment 1 Alex Buckley 2018-08-24 02:41:52 UTC
Created attachment 78103 [details] [review]
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt

Test plan:
1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref

2. Make sure there is a link to self checkout in your customsearch syspref. e.g.:

  <li class="top-level">
    <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl">
      <span class="self-issue">
      Self issue an item
      </span>
    </a>
  </li>

3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs

4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface.

5. Apply patch

6. Refresh the page and notice the custom theme is being applied.

Sponsored-By: Central Agencies (Treasury), New Zealand
Comment 2 Owen Leonard 2018-08-31 13:02:20 UTC
sco-main.tt currently contains a lot of what is in doc-head-close.inc, so we need to make some cuts from the template if we're adding the include. I don't remember off the top of my head why it was done that way, so please double-check that there isn't an unintended effect.
Comment 3 Aleisha Amohia 2019-02-07 22:23:38 UTC
Created attachment 84860 [details] [review]
Bug 21266: (follow-up) Removing duplicate lines and moving code around

Removing duplicates lines from sco-main.tt that are already in
doc-head-close.inc.

Also moving JS code into the jsinclude block and moving CSS code into
the cssinclude block.

Same fixes applied to sco/help.tt
Comment 4 Charles Farmer 2019-02-15 21:40:21 UTC
Created attachment 85201 [details] [review]
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt

Test plan:
1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref

2. Make sure there is a link to self checkout in your customsearch syspref. e.g.:

  <li class="top-level">
    <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl">
      <span class="self-issue">
      Self issue an item
      </span>
    </a>
  </li>

3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs

4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface.

5. Apply patch

6. Refresh the page and notice the custom theme is being applied.

Sponsored-By: Central Agencies (Treasury), New Zealand

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 5 Charles Farmer 2019-02-15 21:40:25 UTC
Created attachment 85202 [details] [review]
Bug 21266: (follow-up) Removing duplicate lines and moving code around

Removing duplicates lines from sco-main.tt that are already in
doc-head-close.inc.

Also moving JS code into the jsinclude block and moving CSS code into
the cssinclude block.

Same fixes applied to sco/help.tt

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 6 Katrin Fischer 2019-02-16 09:27:45 UTC
I feel this needs additional clean-up of the CSS to go with it. The colors in the top navigation bar are off on the fonts and mouse overs and not the same as on the front page. Overall I think the style doesn't work so well here because the sco pages haven't been restyled. At the moment, there are also issues with readabillity and contrast beside it not being so pretty - so I think we need to fix those at least. (Please compare toolbar on top with language switcher before and after change)
Comment 7 Aleisha Amohia 2021-02-23 20:34:08 UTC
Created attachment 117217 [details] [review]
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt

Test plan:
1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref

2. Make sure there is a link to self checkout in your customsearch syspref. e.g.:

  <li class="top-level">
    <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl">
      <span class="self-issue">
      Self issue an item
      </span>
    </a>
  </li>

3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs

4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface.

5. Apply patch

6. Refresh the page and notice the custom theme is being applied.

Sponsored-By: Central Agencies (Treasury), New Zealand

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 8 Aleisha Amohia 2021-02-23 20:34:11 UTC
Created attachment 117218 [details] [review]
Bug 21266: (follow-up) Removing duplicate lines and moving code around

Removing duplicates lines from sco-main.tt that are already in
doc-head-close.inc.

Also moving JS code into the jsinclude block and moving CSS code into
the cssinclude block.

Same fixes applied to sco/help.tt

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 9 Aleisha Amohia 2021-02-23 20:34:15 UTC
Created attachment 117219 [details] [review]
Bug 21266: (follow-up) Remove unnecessary vars passed to template
Comment 10 Aleisha Amohia 2021-02-23 20:35:22 UTC
(In reply to Katrin Fischer from comment #6)
> I feel this needs additional clean-up of the CSS to go with it. The colors
> in the top navigation bar are off on the fonts and mouse overs and not the
> same as on the front page. Overall I think the style doesn't work so well
> here because the sco pages haven't been restyled. At the moment, there are
> also issues with readabillity and contrast beside it not being so pretty -
> so I think we need to fix those at least. (Please compare toolbar on top
> with language switcher before and after change)

Can you please provide some examples or screenshots of what you mean?
Comment 11 Katrin Fischer 2022-03-26 17:53:46 UTC
(In reply to Aleisha Amohia from comment #10)
> (In reply to Katrin Fischer from comment #6)
> > I feel this needs additional clean-up of the CSS to go with it. The colors
> > in the top navigation bar are off on the fonts and mouse overs and not the
> > same as on the front page. Overall I think the style doesn't work so well
> > here because the sco pages haven't been restyled. At the moment, there are
> > also issues with readabillity and contrast beside it not being so pretty -
> > so I think we need to fix those at least. (Please compare toolbar on top
> > with language switcher before and after change)
> 
> Can you please provide some examples or screenshots of what you mean?

I am not sure the comments still apply since then some work probably has been done on the pages. And even back then I might have been missing something. I'd have to check again, but the patches don't apply now :(
Comment 12 Aleisha Amohia 2022-03-28 03:39:49 UTC
Created attachment 132276 [details] [review]
Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt

Test plan:
1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref

2. Make sure there is a link to self checkout in your customsearch syspref. e.g.:

  <li class="top-level">
    <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl">
      <span class="self-issue">
      Self issue an item
      </span>
    </a>
  </li>

3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs

4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface.

5. Apply patch

6. Refresh the page and notice the custom theme is being applied.

Sponsored-By: Central Agencies (Treasury), New Zealand

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 13 Aleisha Amohia 2022-03-28 03:39:54 UTC
Created attachment 132277 [details] [review]
Bug 21266: (follow-up) Removing duplicate lines and moving code around

Removing duplicates lines from sco-main.tt that are already in
doc-head-close.inc.

Also moving JS code into the jsinclude block and moving CSS code into
the cssinclude block.

Same fixes applied to sco/help.tt

Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Comment 14 Aleisha Amohia 2022-03-28 03:39:58 UTC
Created attachment 132278 [details] [review]
Bug 21266: (follow-up) Remove unnecessary vars passed to template
Comment 15 Hammat wele 2022-11-18 15:14:21 UTC
error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt).
error: could not build fake ancestor