Custom stylesheet themes set in the OpacAdditionalStylesheet are not applied to the sco-main.tt page because this page is missing the following lines of code in the header: doc-head-close cssinclude
Created attachment 78103 [details] [review] Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: <li class="top-level"> <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl"> <span class="self-issue"> Self issue an item </span> </a> </li> 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand
sco-main.tt currently contains a lot of what is in doc-head-close.inc, so we need to make some cuts from the template if we're adding the include. I don't remember off the top of my head why it was done that way, so please double-check that there isn't an unintended effect.
Created attachment 84860 [details] [review] Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt
Created attachment 85201 [details] [review] Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: <li class="top-level"> <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl"> <span class="self-issue"> Self issue an item </span> </a> </li> 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 85202 [details] [review] Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
I feel this needs additional clean-up of the CSS to go with it. The colors in the top navigation bar are off on the fonts and mouse overs and not the same as on the front page. Overall I think the style doesn't work so well here because the sco pages haven't been restyled. At the moment, there are also issues with readabillity and contrast beside it not being so pretty - so I think we need to fix those at least. (Please compare toolbar on top with language switcher before and after change)
Created attachment 117217 [details] [review] Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: <li class="top-level"> <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl"> <span class="self-issue"> Self issue an item </span> </a> </li> 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 117218 [details] [review] Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 117219 [details] [review] Bug 21266: (follow-up) Remove unnecessary vars passed to template
(In reply to Katrin Fischer from comment #6) > I feel this needs additional clean-up of the CSS to go with it. The colors > in the top navigation bar are off on the fonts and mouse overs and not the > same as on the front page. Overall I think the style doesn't work so well > here because the sco pages haven't been restyled. At the moment, there are > also issues with readabillity and contrast beside it not being so pretty - > so I think we need to fix those at least. (Please compare toolbar on top > with language switcher before and after change) Can you please provide some examples or screenshots of what you mean?
(In reply to Aleisha Amohia from comment #10) > (In reply to Katrin Fischer from comment #6) > > I feel this needs additional clean-up of the CSS to go with it. The colors > > in the top navigation bar are off on the fonts and mouse overs and not the > > same as on the front page. Overall I think the style doesn't work so well > > here because the sco pages haven't been restyled. At the moment, there are > > also issues with readabillity and contrast beside it not being so pretty - > > so I think we need to fix those at least. (Please compare toolbar on top > > with language switcher before and after change) > > Can you please provide some examples or screenshots of what you mean? I am not sure the comments still apply since then some work probably has been done on the pages. And even back then I might have been missing something. I'd have to check again, but the patches don't apply now :(
Created attachment 132276 [details] [review] Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: <li class="top-level"> <a class="no-hover" href="https://<OPACURL>/cgi-bin/koha/sco/sco-main.pl"> <span class="self-issue"> Self issue an item </span> </a> </li> 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 132277 [details] [review] Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer <charles.farmer@inLibro.com>
Created attachment 132278 [details] [review] Bug 21266: (follow-up) Remove unnecessary vars passed to template
error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt). error: could not build fake ancestor
We're moving away from this as more of our libraries pick up the OpacTrustedCheckout feature instead