Description
Owen Leonard
2018-09-27 14:28:35 UTC
Created attachment 79517 [details] [review] Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 This patch modifies several tools templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Tools -> Export data - Tools -> Calendar - Tools -> Import patrons - Tools -> Inventory - Tools -> Staged MARC management - View batches and batch details Created attachment 80389 [details] [review] Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 This patch modifies several tools templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Tools -> Export data - Tools -> Calendar - Tools -> Import patrons - Tools -> Inventory - Tools -> Staged MARC management - View batches and batch details Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Hi Owen, When adding a new entry to the calendar, the options don't look right. Can you please check? They are very far apart and the .[?] breaks to the next line. Created attachment 80513 [details] [review] Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2 This follow-up corrects CSS which was dependent on YUI-specific markup context. To test, apply the patch, regenerate the staff client CSS, go to Tools -> Calendar. - Click any date on the calendar - In the entry form the checkbox and radio button options should be styled correctly. Created attachment 80580 [details] [review] Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 This patch modifies several tools templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Tools -> Export data - Tools -> Calendar - Tools -> Import patrons - Tools -> Inventory - Tools -> Staged MARC management - View batches and batch details Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 80581 [details] [review] Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2 This follow-up corrects CSS which was dependent on YUI-specific markup context. To test, apply the patch, regenerate the staff client CSS, go to Tools -> Calendar. - Click any date on the calendar - In the entry form the checkbox and radio button options should be styled correctly. Created attachment 80582 [details] [review] Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 This patch modifies several tools templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Tools -> Export data - Tools -> Calendar - Tools -> Import patrons - Tools -> Inventory - Tools -> Staged MARC management - View batches and batch details Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 80583 [details] [review] Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2 This follow-up corrects CSS which was dependent on YUI-specific markup context. To test, apply the patch, regenerate the staff client CSS, go to Tools -> Calendar. - Click any date on the calendar - In the entry form the checkbox and radio button options should be styled correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement, will not be backported to 18.05.x series. |