Bug 21434 - Switch two-column templates to Bootstrap grid: Tools part 2
Summary: Switch two-column templates to Bootstrap grid: Tools part 2
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 20654
  Show dependency treegraph
 
Reported: 2018-09-27 14:28 UTC by Owen Leonard
Modified: 2018-10-14 10:12 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 (13.72 KB, patch)
2018-09-27 14:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 (13.78 KB, patch)
2018-10-11 08:48 UTC, Claire Gravely
Details | Diff | Splinter Review
Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2 (1.43 KB, patch)
2018-10-12 14:35 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 (13.78 KB, patch)
2018-10-14 10:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2 (1.43 KB, patch)
2018-10-14 10:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2 (13.83 KB, patch)
2018-10-14 10:12 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2 (1.48 KB, patch)
2018-10-14 10:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2018-09-27 14:28:35 UTC
These two-column tools templates can be updated to use the Bootstrap grid.

 - tools/export.tt
 - tools/holidays.tt
 - tools/import_borrowers.tt
 - tools/inventory.tt
 - tools/manage-marc-import.tt
Comment 1 Owen Leonard 2018-09-27 14:44:39 UTC
Created attachment 79517 [details] [review]
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Export data
 - Tools -> Calendar
 - Tools -> Import patrons
 - Tools -> Inventory
 - Tools -> Staged MARC management
   - View batches and batch details
Comment 2 Claire Gravely 2018-10-11 08:48:00 UTC
Created attachment 80389 [details] [review]
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Export data
 - Tools -> Calendar
 - Tools -> Import patrons
 - Tools -> Inventory
 - Tools -> Staged MARC management
   - View batches and batch details

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 3 Katrin Fischer 2018-10-11 20:30:58 UTC
Hi Owen,

When adding a new entry to the calendar, the options don't look right. Can you please check? They are very far apart and the .[?] breaks to the next line.
Comment 4 Owen Leonard 2018-10-12 14:35:57 UTC
Created attachment 80513 [details] [review]
Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2

This follow-up corrects CSS which was dependent on YUI-specific markup
context.

To test, apply the patch, regenerate the staff client CSS, go to Tools
-> Calendar.

- Click any date on the calendar
- In the entry form the checkbox and radio button options should be
  styled correctly.
Comment 5 Katrin Fischer 2018-10-14 10:11:54 UTC
Created attachment 80580 [details] [review]
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Export data
 - Tools -> Calendar
 - Tools -> Import patrons
 - Tools -> Inventory
 - Tools -> Staged MARC management
   - View batches and batch details

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Comment 6 Katrin Fischer 2018-10-14 10:11:59 UTC
Created attachment 80581 [details] [review]
Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2

This follow-up corrects CSS which was dependent on YUI-specific markup
context.

To test, apply the patch, regenerate the staff client CSS, go to Tools
-> Calendar.

- Click any date on the calendar
- In the entry form the checkbox and radio button options should be
  styled correctly.
Comment 7 Katrin Fischer 2018-10-14 10:12:44 UTC
Created attachment 80582 [details] [review]
Bug 21434: Update two-column templates with Bootstrap grid: Tools part 2

This patch modifies several tools templates to use the
Bootstrap grid instead of YUI.

This patch also removes obsolete "text/javascript" attributes from
<script> tags and "text/css" attributes from <style> tags in the
modified templates.

To test, apply the patch and view the following pages, confirming that
they look correct at various browser widths:

 - Tools -> Export data
 - Tools -> Calendar
 - Tools -> Import patrons
 - Tools -> Inventory
 - Tools -> Staged MARC management
   - View batches and batch details

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Katrin Fischer 2018-10-14 10:12:48 UTC
Created attachment 80583 [details] [review]
Bug 21434: (follow-up) Switch two-column templates to Bootstrap grid: Tools part 2

This follow-up corrects CSS which was dependent on YUI-specific markup
context.

To test, apply the patch, regenerate the staff client CSS, go to Tools
-> Calendar.

- Click any date on the calendar
- In the entry form the checkbox and radio button options should be
  styled correctly.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>