Bug 21463

Summary: Library is no longer displayed in the overdue list
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, nick, pierre-marc.thibault
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15139
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 18789    
Bug Blocks: 15139, 21464    
Attachments: Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view
Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view
Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view

Description Jonathan Druart 2018-10-01 16:41:56 UTC
Caused by
  commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d
  Bug 18789: Send Koha::Patron object to the templates
Comment 1 Jonathan Druart 2018-10-01 16:44:07 UTC
Created attachment 79745 [details] [review]
Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view

branchcode is no longer retrieved from the SQL query, we should use the
Koha::Patron object instead.

Test plan:
Create some overdues and list them on Home › Circulation › Overdues
=> With this patch applied you should see that the "Library" column is
correctly filled with the patron's library name
Comment 2 Pierre-Marc Thibault 2018-10-05 20:19:26 UTC
Created attachment 80150 [details] [review]
Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view

branchcode is no longer retrieved from the SQL query, we should use the
Koha::Patron object instead.

Test plan:
Create some overdues and list them on Home › Circulation › Overdues
=> With this patch applied you should see that the "Library" column is
correctly filled with the patron's library name

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Comment 3 Katrin Fischer 2018-10-06 19:31:24 UTC
Created attachment 80166 [details] [review]
Bug 21463: (bug 18789 follow-up) Fix library display on the overdue list view

branchcode is no longer retrieved from the SQL query, we should use the
Koha::Patron object instead.

Test plan:
Create some overdues and list them on Home › Circulation › Overdues
=> With this patch applied you should see that the "Library" column is
correctly filled with the patron's library name

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 4 Nick Clemens 2018-10-09 16:22:36 UTC
Awesome work all!

Pushed to master for 18.11
Comment 5 Martin Renvoize 2018-10-15 10:59:20 UTC
Pushed to 18.05.x for 18.05.05
Comment 6 Fridolin Somers 2018-10-24 09:04:50 UTC
Depends on Bug 18789 not in 17.11.x