Summary: | Overdues export is missing lot of fields | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | black23, chris, fridolin.somers, gmcharlt, kyle.m.hall, martin.renvoize, nick, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18789, 21463 | ||
Bug Blocks: | 15139 | ||
Attachments: |
Bug 21464: Fix overdue list export
Bug 21464: Fix overdue list export Bug 21464: Fix overdue list export Bug 21464: Hide patron's title not biblio's title Bug 21464: Fix overdue list export Bug 21464: Hide patron's title not biblio's title |
Description
Jonathan Druart
2018-10-01 16:59:50 UTC
Was also broken by commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists Created attachment 79783 [details] [review] Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly Created attachment 80215 [details] [review] Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Works as expected for me, signing off Created attachment 80236 [details] [review] Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This changes dueborrowertitle to title in the private fields list, both are wrong - it should be borrowertitle. Currently this patch hides the book title when the staff is not allowed to view patron infos Created attachment 80297 [details] [review] Bug 21464: Hide patron's title not biblio's title Sorry about missing that Nick, have signed off the follow up patch. Created attachment 80310 [details] [review] Bug 21464: Fix overdue list export commit e09ed656af5f75a82ccfa29318081e217618c32d Bug 18403: Only display libraries from group in dropdown lists and commit 0ab22e1c7c6b6e8d14a4fb7478ab2a3d42da347d Bug 18789: Send Koha::Patron object to the templates broke the overdue list export. Test plan: Create some overdues Export them: "Home › Circulation › Overdues" then click the link on top of the table. All the different columns of the generated CSV file must be filled correctly Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 80311 [details] [review] Bug 21464: Hide patron's title not biblio's title Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Pushed for 18.11. Thanks all! Pushed to 18.05.x for 18.05.05 Depends on Bug 18789 not in 17.11.x Depends on Bug 18789 not in 17.11.x |