Summary: | Translate notices fail on ACCTDETAILS | ||
---|---|---|---|
Product: | Koha | Reporter: | Hugo Agud <hagud> |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, lucas, m.de.rooy, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 17762 | ||
Bug Blocks: | |||
Attachments: |
Bug 21571: Make ACCTDETAILS translatable
Bug 21571: Make ACCTDETAILS translatable Bug 21571: Make ACCTDETAILS translatable |
Description
Hugo Agud
2018-10-15 13:15:07 UTC
Created attachment 80656 [details] [review] Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email. 80656 - Bug 21571: Make ACCTDETAILS translatable Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21571: Make ACCTDETAILS translatable Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: Your local changes to the following files would be overwritten by merge: C4/Letters.pm Please, commit your changes or stash them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 21571: Make ACCTDETAILS translatable The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21571-Make-ACCTDETAILS-translatable-hKZVxD.patch You have local changes: error: Your local changes to the following files would be overwritten by merge: C4/Letters.pm Created attachment 82324 [details] [review] Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email. Signed-off-by: Hugo Agud <hagud@orex.es> Created attachment 82729 [details] [review] Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.02... it is a bug if something cannot be translated. backported to 18.05 for 18.05.08 Pushed to 17.11.x for 17.11.14 |