Translate notices fails on sending language translation for ACCTDETAILS When creating a new patron at koha and syspref TranslateNotices is enabled and AutoEmailOpacUser is enabled Koha send an email to the patron. It should send a notice according his 'Preferred language for notices:' but is is ignoring and just sendig the default notice, no matter what language has the patron selected. Test plan 1. Go to syspref and enable translate notices and send email to new patronscreatd 2. Go to notices and make sure that ACCTDETAILS is ready for several languages 3. Create a new patron make sure to type a valid email and select a laguange that doesn't match with default language 4. receive the welcome mail
Created attachment 80656 [details] [review] Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email.
80656 - Bug 21571: Make ACCTDETAILS translatable Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21571: Make ACCTDETAILS translatable Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: Your local changes to the following files would be overwritten by merge: C4/Letters.pm Please, commit your changes or stash them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 21571: Make ACCTDETAILS translatable The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21571-Make-ACCTDETAILS-translatable-hKZVxD.patch
You have local changes: error: Your local changes to the following files would be overwritten by merge: C4/Letters.pm
Created attachment 82324 [details] [review] Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email. Signed-off-by: Hugo Agud <hagud@orex.es>
Created attachment 82729 [details] [review] Bug 21571: Make ACCTDETAILS translatable This patch makes the notice "ACCTDETAILS" translatable. Test plan: 1. Switch on TranslateNotices and AutoEmailOpacUser 2. Define templates for different languages for ACCTDETAILS 3. Create a new patron, define an email address, userid and password. Also pick a different "preferred language" then the default value 4. You should receive the email with the correct, translated, email. Signed-off-by: Hugo Agud <hagud@orex.es> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.02... it is a bug if something cannot be translated.
backported to 18.05 for 18.05.08
Pushed to 17.11.x for 17.11.14