Bug 21575

Summary: Fix ArticleRequestsMandatoryFieldsItem(s)Only variants
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14610    
Bug Blocks:    

Description Katrin Fischer 2018-10-15 16:52:34 UTC
The ArticleRequestsMandatoryFieldsItemsOnly shows up on the local use pref tab, because there is a mismatch between what's in the database and what we have in the yaml file and templates:


With S:

installer/data/mysql/sysprefs.sql:('ArticleRequestsMandatoryFieldsItemsOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''item_only''', 'multiple'),
installer/data/mysql/updatedatabase.pl:            ('ArticleRequestsMandatoryFieldsItemsOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''item_only''', 'multiple'),

Without S:

ArticleRequestsMandatoryFieldsItemOnly
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:            - pref: ArticleRequestsMandatoryFieldsItemOnly
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt:            [% IF article_request_type == 'item_only' %] [% SET mandatory_fields = Koha.Preference('ArticleRequestsMandatoryFieldsItemOnly') %]   [% END %]