Bug 21575 - Fix ArticleRequestsMandatoryFieldsItem(s)Only variants
Summary: Fix ArticleRequestsMandatoryFieldsItem(s)Only variants
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 14610
Blocks:
  Show dependency treegraph
 
Reported: 2018-10-15 16:52 UTC by Katrin Fischer
Modified: 2018-10-16 12:34 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2018-10-15 16:52:34 UTC
The ArticleRequestsMandatoryFieldsItemsOnly shows up on the local use pref tab, because there is a mismatch between what's in the database and what we have in the yaml file and templates:


With S:

installer/data/mysql/sysprefs.sql:('ArticleRequestsMandatoryFieldsItemsOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''item_only''', 'multiple'),
installer/data/mysql/updatedatabase.pl:            ('ArticleRequestsMandatoryFieldsItemsOnly', '', NULL, 'Comma delimited list of required fields for bibs where article requests rule = ''item_only''', 'multiple'),

Without S:

ArticleRequestsMandatoryFieldsItemOnly
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:            - pref: ArticleRequestsMandatoryFieldsItemOnly
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-request-article.tt:            [% IF article_request_type == 'item_only' %] [% SET mandatory_fields = Koha.Preference('ArticleRequestsMandatoryFieldsItemOnly') %]   [% END %]