| Summary: | Novelist Select staff client not working in staff client - ns2init.js not loading | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, george, gmcharlt, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 20538 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 21583: Don't use Asset.js for external script files
Bug 21583: Don't use Asset.js for external script files Bug 21583: Don't use Asset.js for external script files |
||
|
Description
Nick Clemens (kidclamp)
2018-10-16 17:09:20 UTC
Created attachment 80668 [details] [review] Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Created attachment 80681 [details] [review] Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Signed-off-by: George Williams <george@nekls.org> Tested on ByWater sandbox. Works as advertised. Created attachment 80684 [details] [review] Bug 21583: Don't use Asset.js for external script files To test: 1 - Enable Novelist in staff client: NovelistSelectStaffEnabled: Add NovelistSelectStaffProfile: anything NovelistSelectPassword: anything ( these don't need to be valid, just not blank ) 2 - Pull up a record detail page in staff client 3 - View page source - search for ns2init.js 4 - You won't find it 5 - Apply patch 6 - Reload details 7 - Search page source for ns2init.js 8 - It loaded! Huzzah! Signed-off-by: George Williams <george@nekls.org> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Awesome work all! Pushed to master for 18.11 Pushed to 18.05.x for 18.05.06 |