Bug 21583

Summary: Novelist Select staff client not working in staff client - ns2init.js not loading
Product: Koha Reporter: Nick Clemens <nick>
Component: Staff interfaceAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: fridolin.somers, george, gmcharlt, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 20538    
Bug Blocks:    
Attachments: Bug 21583: Don't use Asset.js for external script files
Bug 21583: Don't use Asset.js for external script files
Bug 21583: Don't use Asset.js for external script files

Description Nick Clemens 2018-10-16 17:09:20 UTC

    
Comment 1 Nick Clemens 2018-10-16 17:12:41 UTC
Created attachment 80668 [details] [review]
Bug 21583: Don't use Asset.js for external script files

To test:
1 - Enable Novelist in staff client:
    NovelistSelectStaffEnabled: Add
    NovelistSelectStaffProfile: anything
    NovelistSelectPassword: anything
    ( these don't need to be valid, just not blank )
2 - Pull up a record detail page in staff client
3 - View page source - search for ns2init.js
4 - You won't find it
5 - Apply patch
6 - Reload details
7 - Search page source for ns2init.js
8 - It loaded! Huzzah!
Comment 2 ByWater Sandboxes 2018-10-16 20:33:36 UTC
Created attachment 80681 [details] [review]
Bug 21583: Don't use Asset.js for external script files

To test:
1 - Enable Novelist in staff client:
    NovelistSelectStaffEnabled: Add
    NovelistSelectStaffProfile: anything
    NovelistSelectPassword: anything
    ( these don't need to be valid, just not blank )
2 - Pull up a record detail page in staff client
3 - View page source - search for ns2init.js
4 - You won't find it
5 - Apply patch
6 - Reload details
7 - Search page source for ns2init.js
8 - It loaded! Huzzah!

Signed-off-by: George Williams <george@nekls.org>
Comment 3 George Williams (NEKLS) 2018-10-16 20:34:36 UTC
Tested on ByWater sandbox. Works as advertised.
Comment 4 Chris Cormack 2018-10-17 01:02:50 UTC
Created attachment 80684 [details] [review]
Bug 21583: Don't use Asset.js for external script files

To test:
1 - Enable Novelist in staff client:
    NovelistSelectStaffEnabled: Add
    NovelistSelectStaffProfile: anything
    NovelistSelectPassword: anything
    ( these don't need to be valid, just not blank )
2 - Pull up a record detail page in staff client
3 - View page source - search for ns2init.js
4 - You won't find it
5 - Apply patch
6 - Reload details
7 - Search page source for ns2init.js
8 - It loaded! Huzzah!

Signed-off-by: George Williams <george@nekls.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 5 Nick Clemens 2018-10-17 19:26:39 UTC
Awesome work all!

Pushed to master for 18.11
Comment 6 Martin Renvoize 2018-10-26 11:53:00 UTC
Pushed to 18.05.x for 18.05.06
Comment 7 Fridolin Somers 2018-11-09 14:05:42 UTC
Depends on Bug 21583 not in 17.11.x