|
Description
Martin Renvoize (ashimema)
2018-10-22 07:37:22 UTC
Further thoughts on this.. it may be nice to allow scrolling through the release teams in a carousel? Created attachment 80968 [details]
Mockup
To note: I don't expect to see this maintained manually as we currently do.. rather, I'd like to maintain a yaml file of release teams via the release-tools and utilise that in the template. I love the idea. At some point I proposed to have all prior release teams on a carousel, but didn't find the time to do it. This way we could tidy things, like the donating institutions for each release, which are not easily highlighted the way it is now. So the sponsoring institutions could show on the corresponding release tab/page. I like both ideas - have all release teams and have the maintenance team highlighted. It's something I stumbled on when doing release maintenance as well. Created attachment 87776 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 87777 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 88483 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 88484 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 88880 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 88881 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 88882 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 88883 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 88884 [details]
before
Created attachment 88885 [details]
after on a stable release
Created attachment 88886 [details]
after on a development release
I've added some screenshots to show how this looks before this patch, and after this patch when backported to a stable branch and when on the current development version. I'm sure it could be made to look even nicer and to display more than just the current maintenance and your running versions release teams but I think this is a good starting point. Created attachment 88890 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 88891 [details] [review] Bug 21626: Use teams.yaml for teams section This looks great! Great work! Applying: Bug 21626: Use teams.yaml for teams section error: sha1 information is lacking or useless (about.pl). error: could not build fake ancestor Glad to see improvements here, but the two teams next to each other are somehow confusing to me too. Created attachment 89185 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 89186 [details] [review] Bug 21626: Use teams.yaml for teams section Rebased so hopefully applies again now. A branch is also maintained here: https://github.com/PTFS-Europe/koha/tree/bug_21626 Created attachment 89206 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 89207 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 89216 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 89217 [details] [review] Bug 21626: Use teams.yaml for teams section Hi Marcel.. So, how about I add a page to koha-community.org something along the lines: >The release team is a group of people responsible for the development of a given release and also the maintenance of in-support releases during the duration of their release cycle. >An installation of Koha will list two teams on the about page, one for the original team responsible for that versions development and a second for the team currently maintaining it with monthly maintenance releases. >The community hold elections once every six months, during an IRC general meeting, to elect who will be part of the team for the next 6 month development cycle. >The roles in a release team may change from cycle to cycle as we continuously look to improve our workflows but the general makeup of the team is described in reasonable detail on <a href="https://wiki.koha-community.org/wiki/Project_roles">this</a> community wiki page. >A record of previous teams can also be found on the wiki <a href="https://wiki.koha-community.org/wiki/Release_Teams">here</a>. And link to it from the koha about page as part of these enhancements.. I'm also tempted to add in the dates a cycle takes place on the about page so that we clearly show if the 'current' maintenance team is no longer current if a library isn't updating regularly. Created attachment 89253 [details]
new_stable
Feedback from IRC based on screenshot: - capitalize Koha (koha -> Koha) - uncapitalize Team and Manager (Documentation Team -> Documentation team ; Documentation Manager -> Documentation manager) - correct "maintenance" typo (maintainence -> maintenance) - rephrase "the version of Koha you are currently running" -> of your currently installed Koha version (suggestion from a non-native, feel free to write whatever sounds best in English ;) ) - add translation manager to current team - add dates to current maintenance team - alphabetize teams within a role by last name (e.g. QA team : Alex Arnaud, Tomás Cohen Arazi, Chris Cormack, Jonathan Druart, Kyle Hall, Julian Maurice, Josef Moravec, Martin Renvoize, Marcel de Rooy) (not sure about Marcel's name D or R? Ask for preference) Caroline (In reply to Caroline Cyr La Rose from comment #34) > Marcel's name D or R? Ask for preference) > > Caroline Dutch people will sort by R and write de R; non-Dutch will often sort by D and write De R.. I won't mind ;) (In reply to Martin Renvoize from comment #32) > So, how about I add a page to koha-community.org something along the lines: [...] > And link to it from the koha about page as part of these enhancements.. I'm > also tempted to add in the dates a cycle takes place on the about page so > that we clearly show if the 'current' maintenance team is no longer current > if a library isn't updating regularly. If I would be using say 17.11.08, I would see the release team of 17.11 (which is fine) and since .08 normally means that we are in the second maintenance cycle, I might see the second RMaint and the release team of 18.11, right? But since I did not upgrade, that info is already out of date. No sense in contacting these individuals. Imo showing two teams is confusing and hard to explain. If you are in say 18.11 QA team, you will be credited for that on a 18.11 about page, and not on the older versions. Should we use the phrase "Original release team"? Remove the maintainers from that section and separately list all maintainers for that version (say 17.11). System date could indeed tell you if the last maintainer is still in function and if the version is even maintained (assuming three cycles). I think we should postpone this to 19.11 btw. Created attachment 89281 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 89282 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 89283 [details] [review] Bug 21626: (follow-up) Changes based on feedback Created attachment 89295 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 89296 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 89297 [details] [review] Bug 21626: (follow-up) Changes based on feedback Created attachment 89298 [details] [review] Bug 21626: (follow-up) Sort Roles Created attachment 89299 [details] [review] Bug 21626: (follow-up) Performance Improvement Created attachment 89307 [details] [review] Bug 21626: Add teams.yaml to /docs Created attachment 89308 [details] [review] Bug 21626: Use teams.yaml for teams section Created attachment 89309 [details] [review] Bug 21626: (follow-up) Changes based on feedback Created attachment 89310 [details] [review] Bug 21626: (follow-up) Performance Improvement Created attachment 89311 [details] [review] Bug 21626: Add release dates to team Created attachment 89552 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89553 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89554 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89555 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89556 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89557 [details] [review] Bug 21626: (follow-up) Minor tweaks to the columns formatting This patch makes minor markup and CSS changes to improve the column-formatting of team data. The primary goal of these changes is to avoid showing a large blank space when using a development version. Some text has been moved around to avoid validation errors. To test, apply the patch and rebuild the staff client CSS. Release and maintenance team information should be displayed in 3-column sets. The information should look well-formatted when using a development or non-development version. On master Release maintainer and Jenkins maintainer don't display for me - the label shows, but there is no name behind it? While you are on it... do you want to sign off Owen's last patch? Hmm.. not sure I like the followup I'm afraid Owen. I liked the side by side of the two teams and I'm not a major fan of splitting the nicely ordered team list over three columns.. Created attachment 89681 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89682 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89683 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89684 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89685 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89686 [details] [review] Bug 21626: Corrections to typos Created attachment 89687 [details] [review] Bug 21626: (follow-up) Minor tweaks to the columns formatting This patch makes minor markup and CSS changes to improve the column-formatting of team data. The primary goal of these changes is to avoid showing a large blank space when using a development version. Some text has been moved around to avoid validation errors. To test, apply the patch and rebuild the staff client CSS. Release and maintenance team information should be displayed in 3-column sets. The information should look well-formatted when using a development or non-development version. Created attachment 89690 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89691 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89692 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89693 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89694 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89695 [details] [review] Bug 21626: Corrections to typos Created attachment 89696 [details] [review] Bug 21626: (follow-up) Minor tweaks to the columns formatting This patch makes minor markup and CSS changes to improve the column-formatting of team data. The primary goal of these changes is to avoid showing a large blank space when using a development version. Some text has been moved around to avoid validation errors. To test, apply the patch and rebuild the staff client CSS. Release and maintenance team information should be displayed in 3-column sets. The information should look well-formatted when using a development or non-development version. Created attachment 89697 [details] [review] Bug 21626: (follow-up) Template corrections for arrayref Created attachment 89698 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89699 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89700 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89701 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89702 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 89703 [details] [review] Bug 21626: Corrections to typos Created attachment 89704 [details] [review] Bug 21626: (follow-up) Template corrections for arrayref Created attachment 89705 [details] [review] Bug 21626: (follow-up) Minor tweaks to the columns formatting This patch makes minor markup and CSS changes to improve the column-formatting of team data. The primary goal of these changes is to avoid showing a large blank space when using a development version. Some text has been moved around to avoid validation errors. To test, apply the patch and rebuild the staff client CSS. Release and maintenance team information should be displayed in 3-column sets. The information should look well-formatted when using a development or non-development version. Also.. I actually like the abundance of whitespace when running a development version.. it's bringing attention to the fact your running a dev version when really you shouldn't be unless you're a developer. Librarians should never see it, so we're not really saving any screen space when running live. Created attachment 89713 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89714 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89715 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89716 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89717 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89718 [details] [review] Bug 21626: Corrections to typos Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89719 [details] [review] Bug 21626: (follow-up) Template corrections for arrayref Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89720 [details] [review] Bug 21626: (follow-up) Minor tweaks to the columns formatting This patch makes minor markup and CSS changes to improve the column-formatting of team data. The primary goal of these changes is to avoid showing a large blank space when using a development version. Some text has been moved around to avoid validation errors. To test, apply the patch and rebuild the staff client CSS. Release and maintenance team information should be displayed in 3-column sets. The information should look well-formatted when using a development or non-development version. Owen, I hope you won't get grumpy with me, but I agree with Martin here - I like the one column per team layout better than the divided layout with 3 columns. I have obsoleted your patch for now, but noting it for Nick. It works, of course! (In reply to Katrin Fischer from comment #91) > Owen, I hope you won't get grumpy with me, but I agree with Martin here No problem at all! That's how all this is supposed to work :) Repetition: Bug wrangler (3.06, 3.06) Created attachment 89750 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89751 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89752 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89753 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89754 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89755 [details] [review] Bug 21626: Corrections to typos Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89756 [details] [review] Bug 21626: (follow-up) Template corrections for arrayref Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89757 [details] [review] Bug 21626: (QA follow-up) Don't crash on missing teams file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 89758 [details] [review] Bug 21626: (QA follow-up) Embed teams.yaml for debian packages Like history.txt we need to tell some debian/ files to copy teams.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 89759 [details] [review] Bug 21626: (QA follow-up) Remove duplicate roles The teams file contains all roles so we don't need to also list them in the contributors file. This patch removes them from contributors.yaml and relies only on the merging of teams. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Marcel de Rooy from comment #93) > Repetition: > > Bug wrangler (3.06, 3.06) Resolved in final followup.. I forgot I'd added roles into contributors.yaml as part of the previous bug. Patches don't apply for me - maybe a missing dependency? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21626: Add teams.yaml to /docs Applying: Bug 21626: Use teams.yaml for teams section Using index info to reconstruct a base tree... M about.pl M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Auto-merging about.pl CONFLICT (content): Merge conflict in about.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 21626: Use teams.yaml for teams section The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-21626-Use-teamsyaml-for-teams-section-igzqn1.patch Created attachment 89771 [details] [review] Bug 21626: Add teams.yaml to /docs Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89772 [details] [review] Bug 21626: Use teams.yaml for teams section Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89773 [details] [review] Bug 21626: (follow-up) Changes based on feedback Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89774 [details] [review] Bug 21626: (follow-up) Performance Improvement Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89775 [details] [review] Bug 21626: Add release dates to team Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89776 [details] [review] Bug 21626: Corrections to typos Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89777 [details] [review] Bug 21626: (follow-up) Template corrections for arrayref Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 89778 [details] [review] Bug 21626: (QA follow-up) Don't crash on missing teams file Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 89779 [details] [review] Bug 21626: (QA follow-up) Embed teams.yaml for debian packages Like history.txt we need to tell some debian/ files to copy teams.yaml Also pick it for the `make install` process (Makefile.PL) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 89780 [details] [review] Bug 21626: (QA follow-up) Remove duplicate roles The teams file contains all roles so we don't need to also list them in the contributors file. This patch removes them from contributors.yaml and relies only on the merging of teams. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> (In reply to Katrin Fischer from comment #105) > Patches don't apply for me - maybe a missing dependency? > > Apply? [(y)es, (n)o, (i)nteractive] y > Applying: Bug 21626: Add teams.yaml to /docs > Applying: Bug 21626: Use teams.yaml for teams section > Using index info to reconstruct a base tree... > M about.pl > M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt > Falling back to patching base and 3-way merge... > Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt > Auto-merging about.pl > CONFLICT (content): Merge conflict in about.pl > error: Failed to merge in the changes. > Patch failed at 0001 Bug 21626: Use teams.yaml for teams section > The copy of the patch that failed is found in: .git/rebase-apply/patch > When you have resolved this problem run "git bz apply --continue". > If you would prefer to skip this patch, instead run "git bz apply --skip". > To restore the original branch and stop patching run "git bz apply --abort". > Patch left in /tmp/Bug-21626-Use-teamsyaml-for-teams-section-igzqn1.patch Rebased and ready to go Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. |