Summary: | Navigation in Z39.50 result pages not working in Acquisitions | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | david, lucas, m.de.rooy, nick, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
The next page, previous page, and go buttons now work when navigating the search results when adding a record to a basket from an external source.
|
Version(s) released in: | |
Circulation function: | |||
Bug Depends on: | 20038 | ||
Bug Blocks: | |||
Attachments: |
Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions
Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions |
Description
Caroline Cyr La Rose
2018-11-02 18:26:10 UTC
I can confirm - the navigation is broken. Created attachment 82569 [details] [review] Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Created attachment 82575 [details] [review] Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Signed-off-by: David Nind <david@davidnind.com> Noticed that search results displays 'Showing 1 to 20 of 20' at the start and end of every search results page. Should this display the total number of results and the place in the pagination? This doesn't affect fixing up the issue in the bug, but would be good to fix up as well if it is easy enough to do. Created attachment 82587 [details] [review] Bug 21758: Navigation in Z39.50 result pages not working in Acquisitions This patch makes markup corrections to the acquisitions Z39.50 search results template so that the navigation form works correctly. Also changed: Removed invalid type attributes from style and script tags. To test, apply the patch and go to Acquisitions -> Vendor -> Basket. - Add to basket -> From an external source - Perform a Z39.50 search which will return multiple pages of results - On the search results page, use the form at the bottom of the page to navigate through results. Confirm that both the "Go" form and the next/previous buttons work. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Awesome work all! Pushed to master for 18.11 Doesn't apply cleanly. Please rebase for 18.05. Thanks |