Summary: | Add column configuration to hold ratios report | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | martin.renvoize, nick, pierre-marc.thibault |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
URL: | /cgi-bin/koha/circ/reserveratios.pl | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21442 | ||
Bug Blocks: | 19282 | ||
Attachments: |
Bug 21785: Add columns configuration to hold ratios report
Bug 21785: Add columns configuration to hold ratios report Bug 21785: Add columns configuration to hold ratios report |
Description
Owen Leonard
2018-11-07 19:44:18 UTC
Created attachment 82046 [details] [review] Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. The patch doesn't apply. (In reply to Pierre-Marc Thibault from comment #2) > The patch doesn't apply. Did you apply the patch for Bug 21442 first? The patches apply okay for me. (In reply to Owen Leonard from comment #3) > (In reply to Pierre-Marc Thibault from comment #2) > > The patch doesn't apply. > > Did you apply the patch for Bug 21442 first? The patches apply okay for me. Ah ok. I never dealt with a bug depending on another so I didn't for the 21442 entry. Sorry, you are probably right. Created attachment 83298 [details] [review] Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Created attachment 83570 [details] [review] Bug 21785: Add columns configuration to hold ratios report This patch adds column configuration to the hold ratios report DataTable. This patch also amends some JavaScript and markup related to some obsolete jQuery syntax: A hover function was being used to change an element's style on hover. It has been removed in favor of using a link and CSS> To test, apply the patch and view the hold ratios report using a ratio which will return multiple results. Confirm that DataTables controls work correctly: Paging, search, column visibility, export and print. Click a number in the "hold ratio" column of the table and verify that it populates the "hold ratio" field in the "refine results" form in the sidebar. Test setting default column configurations in Administration -> Columns settings. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series |