| Summary: | Writeoff "amount" changed from positive values to negative values. | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Alex C <alexanderchen530+kohabugzilla> |
| Component: | Fines and fees | Assignee: | Bugs List <koha-bugs> |
| Status: | CLOSED WONTFIX | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | tomascohen |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 18100 | ||
| Bug Blocks: | |||
| Attachments: | Example of pos/neg writeoff values. | ||
Alex, could you please give us some steps to reproduce the issue? Or is it related to old vs. new data on your db? (generated by the change obviously) Hi Tomas, I think it's old vs new data prior/after an update, you can take a look at this patron's account: 20165100573549, if you filter only "writeoff" numbers, you can see that writeoff balances prior to 2017 were all positive values shown in red (like fines), but after 2017 they were all negative values shown in green like payments. I believe if you pull a SQL report to show writeoff balances from any db it might show the same thing, I don't think it's specifically our DB. I think you can use the timestamps when 17.05 or 17.11 updates were done to see if the values started to look differently prior/after the updates. Hope my explanation made sense ... sorry I can't find the SQLs I wrote back then when I first discovered this, we were doing library system-wide stats on fines and accounts sent to collection, that's how I found some fines were canceling each other out because of the pos/neg values. Thanks. Alex. I believe this was due to bug 18100, fixed by bug 15894 We also spotted this and removed some of the payment options from the GUI back then to avoid the issue in the db. As this hasn't been revisited or got more comments since end of 2018, I am hopeful that bug 15894 fixed it for good. Please reopen if there is still an issue after updating to a recent version. Hi Katrin, Yes I haven't updated this bug because there wasn't an actual fix so far to uniform the positive write-off values and negative write-off values. Is there a way or patch to batch modify all the previous (red) positive write-off amounts into (green) negative amounts? Thanks. Alex. I believe if the database updates haven't taken care of it, there is no official fix and this might need some work locally :( (In reply to Katrin Fischer from comment #5) > I believe if the database updates haven't taken care of it, there is no > official fix and this might need some work locally :( This turned out to be true. See bug 29559 for some help with the clean-up if you want to do it. |
Created attachment 82653 [details] Example of pos/neg writeoff values. Hi, This is not a recent issue, I discovered it either after 17.05 or 17.11 update. Before the update, writeoff amounts were displayed in "red positive numbers", but after the update, writeoff amounts became "green negative numbers" just like payments. This is not an issue if it's just humans reading it, but it becomes an issue when doing accounting and stats, when I was totaling fines during a certain time range, positive/negative values cancel each other and provide inaccurate total fine amounts. I used ABS() as a workaround, but I hope it can be fixed globally to keep it uniform. Please see attached pics. Also ticket "#49563: Difference in positive and negative values in writeoff charges" has some discussion as well. I also spoke to Kyle regarding this issue at KohaCon18. Thanks. Alex C