Summary: | Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Staff interface | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Josef Moravec <josef.moravec> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, josef.moravec, kelly, lucas, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 18403 | ||
Bug Blocks: | |||
Attachments: |
Bug 21904: Hide libraries outside of the group in the header
Bug 21904: Hide libraries outside of the group in the header Bug 21904: Add missing PROCESS stt Bug 21904: Hide libraries outside of the group in the header Bug 21904: Add missing PROCESS stt |
Description
Nick Clemens (kidclamp)
2018-11-28 18:35:18 UTC
Created attachment 82923 [details] [review] Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search Created attachment 83018 [details] [review] Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Hi Jonathan, I have a fail in the QA script here: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template options_for_libraries: not found Created attachment 85222 [details] [review] Bug 21904: Add missing PROCESS stt Created attachment 85234 [details] [review] Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 85235 [details] [review] Bug 21904: Add missing PROCESS stt Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.04 pushed to 18.05.x for 18.05.11 |