To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search 9 - You get all patrons in the group
Created attachment 82923 [details] [review] Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search
Created attachment 83018 [details] [review] Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Hi Jonathan, I have a fail in the QA script here: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template options_for_libraries: not found
Created attachment 85222 [details] [review] Bug 21904: Add missing PROCESS stt
Created attachment 85234 [details] [review] Bug 21904: Hide libraries outside of the group in the header Fix typo To test: 1 - Create a library group with two libraries 2 - Enable hiding patron info for that group 3 - Find or create a patron at one of those libraries without view_borrower_infos_from_any_libraries permission (but with staff side permission) 4 - Sign in as that staff person 5 - Click 'Patrons' 6 - Click the [+] to expand search options 7 - Set the 'Library' dropdown to a library outside of the group 8 - Search Signed-off-by: Nazlı Çetin <nazli@devinim.com.tr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 85235 [details] [review] Bug 21904: Add missing PROCESS stt Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.04
pushed to 18.05.x for 18.05.11