| Summary: | Clean up style of item detail page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | aleisha, ethan.amohia, hayleypelham, josef.moravec, lucas, martin.renvoize, nick, testopia |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18061 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 21304 | ||
| Bug Blocks: | 20654 | ||
| Attachments: |
Bug 21948: Clean up style of item detail page
Bug 21948: Clean up style of item detail page Bug 21948: Clean up style of item detail page Bug 21948: Clean up style of item detail page |
||
|
Description
Owen Leonard
2018-12-04 19:52:43 UTC
After this work, the bug 18061 could became duplicate, which is absolutely OK ;) Created attachment 82859 [details] [review] Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." (In reply to Josef Moravec from comment #1) > After this work, the bug 18061 could became duplicate This patch makes very minor changes, so there is still plenty of room for a more thorough overhaul if necessary. Patch does not apply. Applying: Bug 21948: Clean up style of item detail page .git/rebase-apply/patch:46: trailing whitespace. <li><span class="label">No. of items:</span> [% count | html %] [% IF ( hiddencount ) %]total ([% showncount | html %] shown / [% hiddencount | html %] hidden) error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 21948: Clean up style of item detail page The copy of the patch that failed is found in: .git/rebase-apply/patch Created attachment 85981 [details] [review] Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." (In reply to Hayley Mapley from comment #4) > Patch does not apply. > error: sha1 information is lacking or useless Usually this kind of error means the patch required a dependency (Bug 21304), but I have rebased both patches to be safe. Created attachment 86045 [details] [review] Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Created attachment 86125 [details] [review] Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Awesome work all! Pushed to master for 19.05 Always nice to have a little tidy up.. pushed to 18.11.x for 18.11.05 not backporting enhancement to 18.05.x |