This patch will convert even more acquisitions templates to use the Bootstrap grid: - ISBDdetail.tt - MARCdetail.tt - detail.tt - imageviewer.tt - issuehistory.tt - labeledMARCdetail.tt - moredetail.tt - results.tt
Created attachment 78343 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history
Created attachment 78375 [details] Next record glitch All looks good except for the Return to Results display. For all examples Next Record is offset on the next line rather than on the same line as Previous Record.
Created attachment 78437 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Created attachment 78491 [details] Next button of the controls in an awkward position.
Controls have been tested with the first and last result. The next button is still in an awkward position when the size is small. When the Next button is inactive and its area become bigger, not all the area is colored in grey because the grey area width is fixed.
Sorry. I assumed CSS files has been changed while SCSS has been and oversee your mention to regenerate CSS. Tests will be redo to validate the patch.
Created attachment 78494 [details] Previous and Next buttons a little hidden at a certain size. There is no longer a problem with the Next button at an awkward position. However, when the browser reach a certain size, the buttons text Previous and Next can be partially covered.
Created attachment 79184 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Created attachment 80405 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history
Created attachment 80406 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Created attachment 81192 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation)
Created attachment 81193 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Comment on attachment 81192 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog Review of attachment 81192 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ +620,5 @@ > + </div> <!-- /.col-sm-10.col-sm-push-2 --> > + > + <div class="col-sm-2 col-sm-pull-10"> > + <aside> > + [% INCLUDE 'admin-menu.inc' %] This should be facets.inc
Created attachment 82179 [details] Search results There is a glitch in search results, see screenshot
Created attachment 82186 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation)
Created attachment 82187 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
(In reply to Josef Moravec from comment #14) > There is a glitch in search results, see screenshot I've fixed the facet.inc error in the newly-added patches, but I haven't addressed this issue. I think this problem only happens after you've changed the width of the browser and buttons in the toolbar have wrapped to a new line. I think this is a relatively uncommon sequence of events, and a page refresh fixes it. This problem needs to be fixed globally for every page which has a floating toolbar (see also Bug 21751). I'm leaning towards suggesting we accept this glitch and work on a follow-up, but I understand if y'all disagree.
Created attachment 84704 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation)
Created attachment 84705 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Created attachment 85980 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Created attachment 86015 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation)
Created attachment 86016 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result.
Created attachment 86022 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86023 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 86126 [details] [review] Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 86127 [details] [review] Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
After applying I get a JS error on search results: TypeError: c is null[Learn More] hc-sticky_18.1200027.js:11:4777 And I have no button to select records in the search results
Created attachment 86753 [details] [review] Bug 21304: (follow-up) Correct hc-sticky configuration This patch corrects the element passed to the hc-sticky plugin to define which element the floating toolbar sticks to. To test, apply the patch and perform a search in the staff client which will return multiple results. Confirm that scrolling down the page triggers the floating toolbar.
Awesome work all! Pushed to master for 19.05
Enhancement, will not be backported to 18.11.x series.