Summary: | CAS URL escaped twice, preventing login | ||
---|---|---|---|
Product: | Koha | Reporter: | Stefan Berndtsson <stefan.berndtsson> |
Component: | Authentication | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | dpavlin, fridolin.somers, jonathan.druart, martin.renvoize, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 21526 | ||
Bug Blocks: | 22585 | ||
Attachments: |
Bug 21973: Do not url escape casServerUrl
Bug 21973: Do not url escape casServerUrl Bug 21973: Do not url escape casServerUrl Bug 21973: Do not url escape casServerUrl |
Description
Stefan Berndtsson
2018-12-07 10:25:40 UTC
Created attachment 82978 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Created attachment 83022 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Created attachment 83169 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83178 [details] [review] Bug 21973: Do not url escape casServerUrl It is already escaped correctly in C4::Auth_with_cas::_url_with_get_params using URI::Escape::uri_escape Note that shibbolethLoginUrl is not and must be url escaped in template ("be consistent, they said") Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Be nice to fix this in with Auth_with_cas or Auth_with_shibboleth to be consistent.. but that work shouldn't hold this patch up. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.01 Not needed for 18.05.x |