Created attachment 87036 [details] [review] remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. This means that %3A%2F%2F is converted to %253A%252F%252F. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file.
*** Bug 23026 has been marked as a duplicate of this bug. ***
Created attachment 90376 [details] [review] Bug 22585: remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
With this patch, there remains: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt: <li><a href="[% casServer.value | url %]"> Can you please check if this needs to be changed as well?
It comes from: C4/Auth.pm 1310 foreach my $key ( keys %$casservers ) { 1311 push @tmplservers, { name => $key, value => login_cas_url( $query, $key, $type ) . "?cas=$key" }; 1312 } So you are right Katrin, it must not be filtered.
Created attachment 90456 [details] [review] Bug 22585: (follow-up) Fix additional occurences
This patch is for OPAC and so more a follow-up for bug 21973. But I am not sure it would make sense to open a third report for it.
(In reply to Jonathan Druart from comment #6) > This patch is for OPAC and so more a follow-up for bug 21973. But I am not > sure it would make sense to open a third report for it. Maybe just retitle this one as "Fix remaning CAS links"?
Created attachment 90554 [details] [review] Bug 22585: remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 90555 [details] [review] Bug 22585: (follow-up) Fix additional occurences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Nice work! Pushed to master for 19.11.00
Pushed to 19.05.x for 19.05.01
backported to 18.11.x for 18.11.07