Bug 22009

Summary: Fix error messages for classification sources and filing rules
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: System AdministrationAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, gmcharlt, lucas, martin.renvoize, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15836    
Bug Blocks:    
Attachments: Bug 22009: Fix error messages for filing rules and splitting rules.
Bug 22009: Fix error messages for filing rules and splitting rules.
Bug 22009: Fix error messages for filing rules and splitting rules.

Description Katrin Fischer 2018-12-17 10:10:59 UTC
There is a doubled up error message that might indicate a problem or oversight:

%s An error occurred when adding this filing rule. Perhaps the code already exists? %s Filing rule updated successfully. %s An error occurred when adding this filing rule. Perhaps the code already exists? 

The filing rule error appears twice.
Comment 1 Katrin Fischer 2018-12-21 00:21:19 UTC
Created attachment 83440 [details] [review]
Bug 22009: Fix error messages for filing rules and splitting rules.

Some error messages were doubled up with different error codes.

To test:
I am not sure how to trigger those from the GUI, might
require a code review/code changes.
Comment 2 Jonathan Druart 2018-12-21 13:14:52 UTC
Created attachment 83464 [details] [review]
Bug 22009: Fix error messages for filing rules and splitting rules.

Some error messages were doubled up with different error codes.

To test:
I am not sure how to trigger those from the GUI, might
require a code review/code changes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Martin Renvoize 2019-02-08 17:02:30 UTC
Created attachment 84889 [details] [review]
Bug 22009: Fix error messages for filing rules and splitting rules.

Some error messages were doubled up with different error codes.

To test:
I am not sure how to trigger those from the GUI, might
require a code review/code changes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize 2019-02-08 17:03:13 UTC
Another simple one to QA.. no regressions and a sane fix.

Passing QA
Comment 5 Nick Clemens (kidclamp) 2019-02-11 18:39:16 UTC
Awesome work all!

Pushed to master for 19.05
Comment 6 Martin Renvoize 2019-02-12 13:16:07 UTC
Pushed to 18.11.x for 18.11.03
Comment 7 Lucas Gass 2019-02-14 23:00:59 UTC
missing dependency, wont backport to 18.05.x