There is a doubled up error message that might indicate a problem or oversight: %s An error occurred when adding this filing rule. Perhaps the code already exists? %s Filing rule updated successfully. %s An error occurred when adding this filing rule. Perhaps the code already exists? The filing rule error appears twice.
Created attachment 83440 [details] [review] Bug 22009: Fix error messages for filing rules and splitting rules. Some error messages were doubled up with different error codes. To test: I am not sure how to trigger those from the GUI, might require a code review/code changes.
Created attachment 83464 [details] [review] Bug 22009: Fix error messages for filing rules and splitting rules. Some error messages were doubled up with different error codes. To test: I am not sure how to trigger those from the GUI, might require a code review/code changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 84889 [details] [review] Bug 22009: Fix error messages for filing rules and splitting rules. Some error messages were doubled up with different error codes. To test: I am not sure how to trigger those from the GUI, might require a code review/code changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Another simple one to QA.. no regressions and a sane fix. Passing QA
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
missing dependency, wont backport to 18.05.x