Summary: | Add ability to send "00" in SIP CV field on checkin success | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall <kyle> |
Component: | SIP2 | Assignee: | Kyle M Hall <kyle> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | colin.campbell, m.de.rooy, martin.renvoize, nick |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 22016 | ||
Attachments: |
Bug 22014: Add ability to send "00" in SIP CV field on checkin success
Bug 22014: Add ability to send "00" in SIP CV field on checkin success Bug 22014: Add ability to send "00" in SIP CV field on checkin success Bug 22014: Add ability to send "00" in SIP CV field on checkin success Bug 22014: Unit tests |
Description
Kyle M Hall
2018-12-17 17:34:08 UTC
Created attachment 83308 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83309 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 83346 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Created attachment 85146 [details] [review] Bug 22014: Add ability to send "00" in SIP CV field on checkin success Some SIP devices ( in this particular case, bin sorting machines from RFID Library Solutions ) require a checkin success to return a CV field of the value "00" rather than no CV field at all. Koha should be able to support this behavior. Test Plan: 1) Apply this patch 2) Enable the new option cv_send_00_on_success for a SIP2 account 3) Restart SIP 4) Check in an item successfully via SIP 5) Note the response contains a CV field with the value '00' Sponsored-by: Pueblo City-County Library District Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jill Kleven <jill.kleven@pueblolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> @RM: Would have been even more convincing with a small test in say t/db/SIP/Message.t Created attachment 85289 [details] [review] Bug 22014: Unit tests Awesome work all! Pushed to master for 19.05 Enhancement, will not be backported to 18.11.x series |