| Summary: | CataloguingLog should be suppressed for item branch transfers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | fridolin.somers, josef.moravec, lucas, martin.renvoize, nick |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 18816 | ||
| Bug Blocks: | 22160 | ||
| Attachments: |
Bug 22097: CataloguingLog should be suppressed for item branch transfers
Bug 22097: CataloguingLog should be suppressed for item branch transfers Bug 22097: CataloguingLog should be suppressed for item branch transfers |
||
|
Description
Kyle M Hall (khall)
2019-01-10 19:31:06 UTC
Created attachment 83773 [details] [review] Bug 22097: CataloguingLog should be suppressed for item branch transfers Bug 18816 missed the fact that a branch transfer triggers ModItem and thus generates an action log line. We should not be creating those action logs, especially considering the transfers table itself already documents the transfer. Test Plan: 1) Enable CataloguingLog 2) Transfer an item to another branch 3) Note the new action log line created 4) Apply this patch 5) Create another item transfer 6) No new action log line should be created! Created attachment 83774 [details] [review] Bug 22097: CataloguingLog should be suppressed for item branch transfers Bug 18816 missed the fact that a branch transfer triggers ModItem and thus generates an action log line. We should not be creating those action logs, especially considering the transfers table itself already documents the transfer. Test Plan: 1) Enable CataloguingLog 2) Transfer an item to another branch 3) Note the new action log line created 4) Apply this patch 5) Create another item transfer 6) No new action log line should be created! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Thanks Owen! Created attachment 84678 [details] [review] Bug 22097: CataloguingLog should be suppressed for item branch transfers Bug 18816 missed the fact that a branch transfer triggers ModItem and thus generates an action log line. We should not be creating those action logs, especially considering the transfers table itself already documents the transfer. Test Plan: 1) Enable CataloguingLog 2) Transfer an item to another branch 3) Note the new action log line created 4) Apply this patch 5) Create another item transfer 6) No new action log line should be created! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Behaviour of ModItem with and without the logging flag is already tested. Awesome work all! Pushed to master for 19.05 Pushed to 18.11.x for 18.11.03 backported to 18.05.x for 18.05.09 |