| Summary: | Untranslatable "Patron note:" in checkout.js | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | f.demians, josef.moravec |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
19.11.00
|
|
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 22490 | ||
| Attachments: |
Bug 22114: Untranslatable "Patron note:" in checkout.js
Bug 22114: Untranslatable "Patron note:" in checkout.js Bug 22114: Untranslatable "Patron note:" in checkout.js |
||
Created attachment 93749 [details] [review] Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" Created attachment 94108 [details] [review] Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Very impressed with the German in the commit message! Created attachment 94795 [details] [review] Bug 22114: Untranslatable "Patron note:" in checkout.js This patch modifies JavaScript used in circulation, replacing an untranslatable English string in the script with a variable defined in strings.inc which can be translated. To test you should have the AllowCheckoutNotes system preference enabled. - Apply the patch and log in to the OPAC as a user who has two or more items checked out. - From the list of checkouts on the "Your summary" page, add a note to two or more checked-out items. - Log in to the staff client and open the checkout page for that user. - In the table of checkouts, check the "Check in" checkbox next to one of the titles you added a note to. - Click "Renew or check in selected items." - A message should appear in that table row showing your note, prefixed with the text "Patron note:" To test translation, update and install the de-DE template: > cd misc/translator > perl translate update de-DE > perl translate install de-DE - Go to Administration -> System preferences and enable the "Deutsch (de-DE)" language under I18N/L10N preferences -> language. - Switch to the "Deutsch" translation. - Go to Ausleihe (Circulation) and check out to the same patron. - In the table of checkouts, check the checkbox in the "Rückgabe" column next to another title you added a note to. - Click the "Markierte Exemplare zurückgeben oder verlängern" button. - A message should appear in that table row showing your note prefixed with the text "Benutzernotizen:" Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Nice work! Pushed to master for 19.11.00 |
just noticed a line in checkout.js that contains a string: $('.patron_note_' + data.itemnumber).html("Patron note: " + data.patronnote); .js files are not translated currently.