Bug 22490 - Some strings in javascript files are untranslatable
Summary: Some strings in javascript files are untranslatable
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Fridolin SOMERS
QA Contact: Testopia
: 22601 (view as bug list)
Depends on: 22114 22904
  Show dependency treegraph
Reported: 2019-03-11 11:20 UTC by Josef Moravec
Modified: 2019-12-11 09:38 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Who signed the patch off:
Text to go in the release notes:
Version(s) released in:


Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2019-03-11 11:20:14 UTC
You can find them easily with these commands:

git grep "_(" koha-tmpl/intranet-tmpl/prog/js

git grep "_(" koha-tmpl/opac-tmpl/bootstrap/js

They should be fixed, see https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript
Comment 1 Fridolin SOMERS 2019-03-28 09:04:59 UTC
*** Bug 22601 has been marked as a duplicate of this bug. ***
Comment 2 Fridolin SOMERS 2019-03-28 11:11:48 UTC
I will create a xxx-strings.inc for each js
Comment 3 Jonathan Druart 2019-06-23 15:47:06 UTC
A Koha test must be provided here.
Comment 4 Jonathan Druart 2019-12-11 09:37:54 UTC
Won't be a problem with bug 21156.
Comment 5 Jonathan Druart 2019-12-11 09:38:17 UTC
Lowering severity.