Bug 22118

Summary: Format hold fee when placing holds in OPAC
Product: Koha Reporter: Katrin Fischer <katrin.fischer>
Component: OPACAssignee: Katrin Fischer <katrin.fischer>
Status: CLOSED FIXED QA Contact: Josef Moravec <josef.moravec>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, josef.moravec, lucas, martin.renvoize, nick, sandboxes
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on:    
Bug Blocks: 22112    
Attachments: Bug 22118: Format hold fee when placing holds in OPAC
Bug 22118: Format hold fee when placing holds in OPAC
Bug 22118: Format hold fee when placing holds in OPAC
Bug 22118: Format hold fee when placing holds in OPAC

Description Katrin Fischer 2019-01-12 08:20:30 UTC

    
Comment 1 Katrin Fischer 2019-01-12 08:34:13 UTC
Created attachment 83838 [details] [review]
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct
Comment 2 Biblibre Sandboxes 2019-01-14 23:13:11 UTC
Patch tested with a sandbox, by Jack Kelliher <jke0429@stacmail.net>
Comment 3 Biblibre Sandboxes 2019-01-14 23:13:33 UTC
Created attachment 83920 [details] [review]
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429@stacmail.net>
Comment 4 Katrin Fischer 2019-01-15 06:16:40 UTC
Thank you!
Comment 5 Mikaƫl Olangcay Brisebois 2019-01-18 22:19:37 UTC
Created attachment 84231 [details] [review]
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429@stacmail.net>
Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com>
Comment 6 Josef Moravec 2019-01-21 15:43:29 UTC
Created attachment 84267 [details] [review]
Bug 22118: Format hold fee when placing holds in OPAC

When Koha charges for holds, a message with the fee is
shown before the patron places the hold. The amount needs
to be formatted according to CurrencyFormat system preference.

To test:
- Add a hold fee to your patron category
- Log into the OPAC
- Search for a record to place a hold on
- Click Place hold
- Verify there is a note showing about the hold fee
- Toggle CurrencyFormat and HoldFeeMode and verify
  that the formatting is always correct

Signed-off-by: Jack Kelliher <jke0429@stacmail.net>
Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Nick Clemens (kidclamp) 2019-01-25 17:57:30 UTC
Awesome work all!

Pushed to master for 19.05
Comment 8 Martin Renvoize 2019-01-31 16:39:29 UTC
Pushed to 18.11.x for 18.11.03
Comment 9 Lucas Gass 2019-02-01 21:48:20 UTC
pushed to 18.05.x for 18.05.09
Comment 10 Fridolin Somers 2019-02-04 12:32:43 UTC
Pushed to 17.11.x for 17.11.15