Created attachment 83838 [details] [review] Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct
Patch tested with a sandbox, by Jack Kelliher <jke0429@stacmail.net>
Created attachment 83920 [details] [review] Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct Signed-off-by: Jack Kelliher <jke0429@stacmail.net>
Thank you!
Created attachment 84231 [details] [review] Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct Signed-off-by: Jack Kelliher <jke0429@stacmail.net> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com>
Created attachment 84267 [details] [review] Bug 22118: Format hold fee when placing holds in OPAC When Koha charges for holds, a message with the fee is shown before the patron places the hold. The amount needs to be formatted according to CurrencyFormat system preference. To test: - Add a hold fee to your patron category - Log into the OPAC - Search for a record to place a hold on - Click Place hold - Verify there is a note showing about the hold fee - Toggle CurrencyFormat and HoldFeeMode and verify that the formatting is always correct Signed-off-by: Jack Kelliher <jke0429@stacmail.net> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 19.05
Pushed to 18.11.x for 18.11.03
pushed to 18.05.x for 18.05.09
Pushed to 17.11.x for 17.11.15