Description
Chris Cormack
2010-05-21 00:47:57 UTC
This is still actual. We do not need frameworkcode in this table, we have authtypecode. Let's remove this field now ! Could there be a use case for multiple frameworks for an auth_type or would that not work anyway? (In reply to Katrin Fischer from comment #2) > Could there be a use case for multiple frameworks for an auth_type or would > that not work anyway? That does not work. An authtype is a framework. I am not aware of a realistic use case for this scenario. Created attachment 132832 [details] [review] Bug 2222: Adjust kohastructure Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132833 [details] [review] Bug 2222: Adjust SQL en marc21/unimarc yml and sql file Test plan: Run a new install for en/marc21 testing the yml file. I tested the unimarc sql file as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132834 [details] [review] Bug 2222: Adjust SQL fr-FR Obligatoire file authorities_normal_marc21.sql Test plan: I tested this sql script as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132835 [details] [review] Bug 2222: Adjust SQL fr-FR unimarc complet Obligatoire default I tested this sql script as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132836 [details] [review] Bug 2222: Adjust SQL fr-FR unimarc complete Obligatoire norme This is a large file where frameworkcode is not the last field in each row. So harder to replace since the contents of the last field varies. Awaiting migration to yaml, I chose here to add and drop the column ;) Test plan: I tested this sql script as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132837 [details] [review] Bug 2222: Adjust SQL fr-FR unimarc lecture Obligatoire norme I tested the sql file as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132838 [details] [review] Bug 2222: Database revision Test plan: Run updatedatabase.pl on existing data. Check database columns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132839 [details] [review] Bug 2222: Modify C4::AuthoritiesMarc::GetTagsLabels and callers We adjust two callers here to rename the parameter from framework to authtypecode in order to prevent confusion. Still needs some attention; work in progress Created attachment 132840 [details] [review] Bug 2222: Database revision Test plan: Run updatedatabase.pl on existing data. Check database columns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 132841 [details] [review] Bug 2222: Modify C4::AuthoritiesMarc::GetTagsLabels and callers We adjust two callers here to rename the parameter from framework to authtypecode in order to prevent confusion. TODO Lost my merge_ajax changes somewhere ;) (In reply to Marcel de Rooy from comment #1) > This is still actual. > We do not need frameworkcode in this table, we have authtypecode. > Let's remove this field now ! This was a dumb exercise. There are a few see also fields that need it. Title changed accordingly :) |