---- Reported by rch@liblime.com 2008-06-06 10:22:26 ---- UNIMARC-specific : to allow for bt - nt relationships, the authorities framework holds an authtypecode associated with a subfield definition. it stores the authtypecode in auth_subfield_structure.frameworkcode, which is a varchar(8) , not a varchar(10) . ---- Additional Comments From nengard@gmail.com 2009-12-23 17:59:01 ---- This bug hasn't been touched in nearly a year, please revisit and test and close if appropriate. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 00:47 UTC --- This bug was previously known as _bug_ 2222 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2222 Actual time not defined. Setting to 0.0 The original reporter of this bug does not have an account here. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. Previous reporter was rch@liblime.com.
This is still actual. We do not need frameworkcode in this table, we have authtypecode. Let's remove this field now !
Could there be a use case for multiple frameworks for an auth_type or would that not work anyway?
(In reply to Katrin Fischer from comment #2) > Could there be a use case for multiple frameworks for an auth_type or would > that not work anyway? That does not work. An authtype is a framework. I am not aware of a realistic use case for this scenario.
Created attachment 132832 [details] [review] Bug 2222: Adjust kohastructure Test plan: See next patch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132833 [details] [review] Bug 2222: Adjust SQL en marc21/unimarc yml and sql file Test plan: Run a new install for en/marc21 testing the yml file. I tested the unimarc sql file as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132834 [details] [review] Bug 2222: Adjust SQL fr-FR Obligatoire file authorities_normal_marc21.sql Test plan: I tested this sql script as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132835 [details] [review] Bug 2222: Adjust SQL fr-FR unimarc complet Obligatoire default I tested this sql script as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132836 [details] [review] Bug 2222: Adjust SQL fr-FR unimarc complete Obligatoire norme This is a large file where frameworkcode is not the last field in each row. So harder to replace since the contents of the last field varies. Awaiting migration to yaml, I chose here to add and drop the column ;) Test plan: I tested this sql script as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132837 [details] [review] Bug 2222: Adjust SQL fr-FR unimarc lecture Obligatoire norme I tested the sql file as follows: (sql) delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types; (bash) mysql -h YOUR_HOST -p YOUR_CLONE < FILE_NAME Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132838 [details] [review] Bug 2222: Database revision Test plan: Run updatedatabase.pl on existing data. Check database columns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132839 [details] [review] Bug 2222: Modify C4::AuthoritiesMarc::GetTagsLabels and callers We adjust two callers here to rename the parameter from framework to authtypecode in order to prevent confusion.
Still needs some attention; work in progress
Created attachment 132840 [details] [review] Bug 2222: Database revision Test plan: Run updatedatabase.pl on existing data. Check database columns. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 132841 [details] [review] Bug 2222: Modify C4::AuthoritiesMarc::GetTagsLabels and callers We adjust two callers here to rename the parameter from framework to authtypecode in order to prevent confusion.
TODO Lost my merge_ajax changes somewhere ;)
(In reply to Marcel de Rooy from comment #1) > This is still actual. > We do not need frameworkcode in this table, we have authtypecode. > Let's remove this field now ! This was a dumb exercise. There are a few see also fields that need it. Title changed accordingly :)