Summary: | Mana subscription search always returns all results | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Web services | Assignee: | Josef Moravec <josef.moravec> |
Status: | CLOSED FIXED | QA Contact: | Alex Arnaud <alex.arnaud> |
Severity: | major | ||
Priority: | P5 - low | CC: | alex.arnaud, jonathan.druart, josef.moravec, katrin.fischer, martin.renvoize, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 17047 | ||
Bug Blocks: | |||
Attachments: |
Bug 22222: Don't send empty params to mana service
Bug 22222: Don't send empty params to mana service Bug 22222: Don't send empty params to mana service |
Description
Owen Leonard
2019-01-29 02:00:38 UTC
Created attachment 86043 [details] [review] Bug 22222: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query Created attachment 86396 [details] [review] Bug 22222: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query Signed-off-by: Michal Denar <black23@gmail.com> Created attachment 86508 [details] [review] Bug 22222: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> (In reply to Alex Arnaud from comment #3) > Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Thanks Alex Awesome work all! Pushed to master for 19.05 Bug with enhancement not in 18.11.x series. |