Created attachment 56175 [details] [review]
Bug 17047 add mana syspref

Add the system preference to enable or disable mana
webservice on koha.

Created attachment 56176 [details] [review]
Bug 17047 add frequencies and numberpattern in subscription class

Created attachment 56177 [details] [review]
Bug 17047 ability to search subscription model on mana

- add a class SharedContent.pm to communicate with mana server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for mana
- create datatable in mana-subscription-search-result.inc to show
results from a research on mana
- modify serials-search.pl to manage research on mana

Created attachment 56178 [details] [review]
Bug 17047 ability to share a subscription to mana

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a mana subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to mana

Created attachment 56179 [details] [review]
Bug 17047 ability to import a subscription model from mana

- modify subscription-add.tt and subscription.pl to manage a
import from mana during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with mana server during a asubscription creation
- add a function in Subscription.pm to have all the info for a mana research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from mana server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 56180 [details] [review]
Bug 17047 Add unit tests

Created attachment 56181 [details] [review]
Bug 17047 - Use Koha::Libraries instead of GetBranches

Created attachment 59728 [details] [review]
Bug 17047 - Don't create numberpattern if the same exists

Created attachment 59729 [details] [review]
Bug 17047 - Remove action column from mana search result table

Created attachment 59931 [details] [review]
Bug 17047 - Don't show action column (use link) on mana search page

Created attachment 61905 [details] [review]
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of users
- Windows redisigned to improve the user experience
- New Feature : report a record.
     - peoples can now report a weird report
     - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
- no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
    - add a field "no, let me think" at the syspref "Mana"
    - as long as this field is selected, messages ask if user want to activate it
    messages in pages:
    - Administration
    - Add-subscription(page 2)
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a Share button)
- Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 62045 [details] [review]
Bug 17047 add mana syspref

Add the system preference to enable or disable mana
webservice on koha.

Created attachment 62046 [details] [review]
Bug 17047 add frequencies and numberpattern in subscription class

Created attachment 62047 [details] [review]
Bug 17047 ability to search subscription model on mana

- add a class SharedContent.pm to communicate with mana server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for mana
- create datatable in mana-subscription-search-result.inc to show
results from a research on mana
- modify serials-search.pl to manage research on mana

Created attachment 62048 [details] [review]
Bug 17047 ability to share a subscription to mana

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a mana subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to mana

Created attachment 62049 [details] [review]
Bug 17047 ability to import a subscription model from mana

- modify subscription-add.tt and subscription.pl to manage a
import from mana during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with mana server during a asubscription creation
- add a function in Subscription.pm to have all the info for a mana research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from mana server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 62050 [details] [review]
Bug 17047 Add unit tests

Created attachment 62051 [details] [review]
Bug 17047 - Use Koha::Libraries instead of GetBranches

Created attachment 62052 [details] [review]
Bug 17047 - Don't create numberpattern if the same exists

Created attachment 62053 [details] [review]
Bug 17047 - Don't show action column (use link) on mana search page

Created attachment 62054 [details] [review]
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of users
- Windows redisigned to improve the user experience
- New Feature : report a record.
     - peoples can now report a weird report
     - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
- no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
    - add a field "no, let me think" at the syspref "Mana"
    - as long as this field is selected, messages ask if user want to activate it
    messages in pages:
    - Administration
    - Add-subscription(page 2)
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a Share button)
- Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 62075 [details] [review]
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of users
- Windows redisigned to improve the user experience
- New Feature : report a record.
     - peoples can now report a weird report
     - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
- no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
    - add a field "no, let me think" at the syspref "Mana"
    - as long as this field is selected, messages ask if user want to activate it
    messages in pages:
    - Administration
    - Add-subscription(page 2)
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a Share button)
- Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 62465 [details] [review]
Bug 17047: Add security token against spam, Rework messages from Mana.

- A syspref contains an authentication token
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - Report
      - Create a new report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Comments.
      - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
      - If you click on other, a new textbox appears. Enter a short comment.
      - Reload the whole page, the comment should appear in the menu and in the comment column.
      - If you select a comment and reload the whole page, there should be one more comment with this name
      - If you select a comment and click on cancel just after, there shouldn't be any change when you reload.
      - If to a result has been reported a lot (>5, >10 and >15), it should appear differently

    8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message.

Created attachment 62475 [details] [review]
Bug 17047: Add security token against spam, Rework messages from Mana.

- A syspref contains an authentication token
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - Report
      - Create a new report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Comments.
      - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
      - If you click on other, a new textbox appears. Enter a short comment.
      - Reload the whole page, the comment should appear in the menu and in the comment column.
      - If you select a comment and reload the whole page, there should be one more comment with this name
      - If you select a comment and click on cancel just after, there shouldn't be any change when you reload.
      - If to a result has been reported a lot (>5, >10 and >15), it should appear differently

    8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message.

Created attachment 62485 [details] [review]
Bug 17047: Add security token against spam, Rework messages from Mana.

- A syspref contains an authentication token
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - Report
      - Create a new report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Comments.
      - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
      - If you click on other, a new textbox appears. Enter a short comment.
      - Reload the whole page, the comment should appear in the menu and in the comment column.
      - If you select a comment and reload the whole page, there should be one more comment with this name
      - If you select a comment and click on cancel just after, there shouldn't be any change when you reload.
      - If to a result has been reported a lot (>5, >10 and >15), it should appear differently

    8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message.

Created attachment 62540 [details] [review]
Bug 17047: minor corrections on report share

- Use a report now redirects on the created report

Created attachment 62542 [details] [review]
Bug 17047 add mana syspref

Add the system preference to enable or disable mana
webservice on koha.

Created attachment 62543 [details] [review]
Bug 17047 add frequencies and numberpattern in subscription class

Created attachment 62544 [details] [review]
Bug 17047 ability to search subscription model on mana

- add a class SharedContent.pm to communicate with mana server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for mana
- create datatable in mana-subscription-search-result.inc to show
results from a research on mana
- modify serials-search.pl to manage research on mana

Created attachment 62545 [details] [review]
Bug 17047 ability to share a subscription to mana

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a mana subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to mana

Created attachment 62546 [details] [review]
Bug 17047 ability to import a subscription model from mana

- modify subscription-add.tt and subscription.pl to manage a
import from mana during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with mana server during a asubscription creation
- add a function in Subscription.pm to have all the info for a mana research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from mana server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 62547 [details] [review]
Bug 17047 Add unit tests

Created attachment 62548 [details] [review]
Bug 17047 - Use Koha::Libraries instead of GetBranches

Created attachment 62549 [details] [review]
Bug 17047 - Don't create numberpattern if the same exists

Created attachment 62550 [details] [review]
Bug 17047 - Don't show action column (use link) on mana search page

Created attachment 62551 [details] [review]
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of users
- Windows redisigned to improve the user experience
- New Feature : report a record.
     - peoples can now report a weird report
     - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
- no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
    - add a field "no, let me think" at the syspref "Mana"
    - as long as this field is selected, messages ask if user want to activate it
    messages in pages:
    - Administration
    - Add-subscription(page 2)
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a Share button)
- Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 62552 [details] [review]
Bug 17047: Add security token against spam, Rework messages from Mana.

- A syspref contains an authentication token
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - Report
      - Create a new report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Comments.
      - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
      - If you click on other, a new textbox appears. Enter a short comment.
      - Reload the whole page, the comment should appear in the menu and in the comment column.
      - If you select a comment and reload the whole page, there should be one more comment with this name
      - If you select a comment and click on cancel just after, there shouldn't be any change when you reload.
      - If to a result has been reported a lot (>5, >10 and >15), it should appear differently

    8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message.

Created attachment 62553 [details] [review]
Bug 17047: minor corrections on report share

Created attachment 62589 [details] [review]
Bug 17047: Add report_group as shared attribute

Created attachment 62591 [details] [review]
Bug 17047 add mana syspref

Add the system preference to enable or disable mana
webservice on koha.

Created attachment 62592 [details] [review]
Bug 17047 add frequencies and numberpattern in subscription class

Created attachment 62593 [details] [review]
Bug 17047 ability to search subscription model on mana

- add a class SharedContent.pm to communicate with mana server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for mana
- create datatable in mana-subscription-search-result.inc to show
results from a research on mana
- modify serials-search.pl to manage research on mana

Created attachment 62594 [details] [review]
Bug 17047 ability to share a subscription to mana

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a mana subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to mana

Created attachment 62595 [details] [review]
Bug 17047 ability to import a subscription model from mana

- modify subscription-add.tt and subscription.pl to manage a
import from mana during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with mana server during a asubscription creation
- add a function in Subscription.pm to have all the info for a mana research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from mana server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 62596 [details] [review]
Bug 17047 - Don't create numberpattern if the same exists

Created attachment 62597 [details] [review]
Bug 17047 Add unit tests

Created attachment 62598 [details] [review]
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of users
- Windows redisigned to improve the user experience
- New Feature : report a record.
     - peoples can now report a weird report
     - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
- no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
    - add a field "no, let me think" at the syspref "Mana"
    - as long as this field is selected, messages ask if user want to activate it
    messages in pages:
    - Administration
    - Add-subscription(page 2)
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a Share button)
- Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 62599 [details] [review]
Bug 17047: Add security token against spam, Rework messages from Mana.

- A syspref contains an authentication token
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages ar now correctly displayed and there shouldn't be any crash when mana answer wrong/doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => mana shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - Report
      - Create a new report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on mana KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Comments.
      - On any table containing mana search results, you can comment. To comment, click on report mistake. For now, you only can chose "other".
      - If you click on other, a new textbox appears. Enter a short comment.
      - Reload the whole page, the comment should appear in the menu and in the comment column.
      - If you select a comment and reload the whole page, there should be one more comment with this name
      - If you select a comment and click on cancel just after, there shouldn't be any change when you reload.
      - If to a result has been reported a lot (>5, >10 and >15), it should appear differently

    8 - For each precedent test, try to send wrong datas, to delete the security token, to send nothing: it should send you a propper message.

Created attachment 63619 [details] [review]
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 63620 [details] [review]
Bug 17047 Mana-KB, Add unit tests

Created attachment 63621 [details] [review]
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
    - no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a Share button)
- Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 63622 [details] [review]
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.

Created attachment 63623 [details] [review]
Bug 17047: Correct encoding issues

Modify the function manaRequest in order to set the right encoding format (UTF-8).

Created attachment 64484 [details] [review]
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from Mana.
- Error messages are displayed in case of fail

Created attachment 64530 [details] [review]
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from Mana.
- Error messages are displayed in case of fail

Hi !
It is on my todo list, I'll rebase it soon, take a bit time cause it concerns tests I didn't change by myself and I'm not pretty sure ;)

Created attachment 64618 [details] [review]
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Created attachment 64619 [details] [review]
Bug 17047: subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 64620 [details] [review]
Bug 17047 Mana-KB, Add unit tests

Created attachment 64621 [details] [review]
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
    - no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a Share button)
- Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 64622 [details] [review]
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.

Created attachment 64623 [details] [review]
Bug 17047: Correct encoding issues

Modify the function manaRequest in order to set the right encoding format (UTF-8).

Created attachment 64624 [details] [review]
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from Mana.
- Error messages are displayed in case of fail

Created attachment 64625 [details] [review]
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Created attachment 64626 [details] [review]
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 64627 [details] [review]
Bug 17047 Mana-KB, Add unit tests

Created attachment 64628 [details] [review]
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
    - no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a Share button)
- Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 64629 [details] [review]
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.

Created attachment 64630 [details] [review]
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.

Created attachment 64631 [details] [review]
Bug 17047: Correct encoding issues

Modify the function manaRequest in order to set the right encoding format (UTF-8).

Created attachment 64632 [details] [review]
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from Mana.
- Error messages are displayed in case of fail

Created attachment 64633 [details] [review]
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 64634 [details] [review]
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Created attachment 64635 [details] [review]
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 64636 [details] [review]
Bug 17047 add Mana-KB syspref

Add the system preference to enable or disable Mana-KB webservice on koha.

Created attachment 64637 [details] [review]
Bug 17047 subscriptions management with Mana-KB

- add a class SharedContent.pm to communicate with Mana-KB server
- add a link in serials-menu.inc to serials_search.pl to open
a mana-subscription research form
- modify the research form in serials-search.tt to show the right fields
for Mana-KB
- create datatable in mana-subscription-search-result.inc to show
results from a research on Mana-KB
- modify serials-search.pl to manage research on Mana-KB

- add a mana_id to subscription table
- add a share button on serials-toolbar.inc and a modal to ask
the language of the share and to alert if the subscription is
already link to a Mana-KB subscription model
- add function in C4/Serials to get all the info for a subscription
sharing
- modify subscription-detail.pl to manage sharing to Mana-KB

- modify subscription-add.tt and subscription.pl to manage a
import from Mana-KB during a subscription creation
- add 2 script in svc for ajax calling from subscription-add.tt
to communicate with Mana-KB server during a asubscription creation
- add a function in Subscription.pm to have all the info for a Mana-KB research
from a biblionumber
- modify functions used by subscription-add.pl in C4/Serials to manage a
frequency which came from Mana-KB server and not already created on the
koha database, and modify the tests of the said functions

Created attachment 64638 [details] [review]
Bug 17047 Mana-KB, Add unit tests

Created attachment 64639 [details] [review]
Bug 17047 SQL reports management with Mana-KB

Includes:

* code factorization
Some code from subscription & Mana-KB has been factorized in order to speed-up next developments

* SytemPreferences:
Mana Activation:
    - add a value "no, let me think about it", that is the default value.
    - as long as this value is selected, messages ask if user want to activate it ( in Administration and Add-subscription(page 2) )
AutoShareWithMana
    - Add the syspref AutoShareWithMana: user can automatically share infos with Mana-KB (not set by default)

* Interface :
    - On mana-search, rows are now sorted by date of last import, then by number of users
    - Windows redesigned to improve the user experience

* New Feature : report a mistake.
    - people can now report an invalid data (wrong, obsolete,...)
    - if a data is reported as invalid many time, it will appear differently
    - Added few tooltip (to explain the fields last import, nb of users, to explain the new feature)
    - When reporting a data as invalid, a comment can also be added. Koha will then display comments related to data in result lists

* API (svc/mana)
    - add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a resource
    - no hardcoding for resources in the code of api (api needs to be called with a ressourcename)

* New feature : SQL report sharing
    - Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
    - New feature: share reports with Mana-KB
    - New feature: search report in Mana-KB with keywords
    - New feature: load reports from Mana-KB

=========
Test plan
=========
(see BibLibre complete documentation, attached to this patch)
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => Koha shouldn't show you anything (except if the base hase been filled)
- Share this serial on Mana-KB (on the subscription detail page there must be a Share button)
- Try to create a new subscription for serial #1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - SQL Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You can share it on Mana-KB => you will have a success message
- On (report > use saved), there must be a message inviting you to search on mana-KB for more results, enter a few word from title, notes, type of the report you shared, it should appear. You can use it, it will load it into your report list.

6 - Comments.
- On any table containing mana search results, you can report a mistake & comment why you report: click on report mistake. You only can chose "other" because there's no comment in Mana-KB [if there are comments, you'll get other values].
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the comment column.
- If you select a comment and reload the whole page, there should be one more comment with this name
- If you select a comment and click on cancel just after, there shouldn't be any change when you reload.

Created attachment 64640 [details] [review]
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.

Created attachment 64641 [details] [review]
Bug 17047 security token agst flooding for Mana-KB

Rework messages from Mana-KB.

- Add A syspref contains an authentication token. The token will be used to prevent anaonymous flooding of Mana-KB
- To get an Authentication token, you have to fill a form and validate your e-mail address
- Messages return codes are now correctly displayed and there shouldn't be any crash when Mana-KB webservices return a wrong answer or doesn't answer

Test plan:
    1 - Apply Patch + update database
    2 - Copy the three lines about mana config in etc/koha-conf.xml in ../etc/koha-conf.xml (after <backupdir> for example)
        <!-- URL of the mana KB server -->
        <!-- alternative value http://mana-test.koha-community.org to query the test server -->
        <mana_config>https://mana-kb.koha-community.org</mana_config>
    3 - Check Mana syspref and AutoShareWithMana syspref are not activated
    4 - Search the syspref ManaToken and follow the instructions
    5 - subscriptions
      - Try create a new subscription for a first serial  => Mana-KB shouldn't show you anything (except if the base hase been filled)
      - Share this serial with Mana-KB (on the serial individual's page there must be a Share button)
      - Try to create a new subscription for serial nr1 => a message should appear when you click on "next", click on "use", the fields should automaticaly appear
      - Activate AutoShareWithMana => Subscriptions
      - Create a new subscription for a second serial
      - There shouldn't be any Share button
      - Create a second subscription => the message should appear, click again on use

    6 - SQL Report
      - Create a new SQL report, without notes.
      - On the table with all report (reports > use saved), there should be the action "Share"
      - If you click on share, you have an error message
      - Create a new report, with a title and notes longer than 20 characters
      - You  can share it with mana => you will have a success message
      - On (report > use saved), there must be a message inviting you to search on Mana-KB for more results, enter a few word from title, notes, type of  the report you shared, it should appear. You can use it, it will load it into your report list.

    7 - Report mistakes.
      - On any table containing Mana-KB search results, you can report a mistake and add a comment.

    8 - For each previous test, try to send wrong data, to delete the security token, to send nothing: it should show a correct warning message.

Created attachment 64642 [details] [review]
Bug 17047: Correct encoding issues

Modify the function manaRequest in order to set the right encoding format (UTF-8).

Created attachment 64643 [details] [review]
Bug 17047: Minor changes

- search on reports module is now also validated by pressing enter.
- AutoShare now initialized with nothing autmaticaly shared.
- To create a report you now have to click on New report => New report from Mana.
- Error messages are displayed in case of fail